[web] Show @-mentions in pending threads
ClosedPublic
Actions

Authored by ashoat on Feb 17 2023, 8:55 AM.

Tags

None

Referenced Files

	F3246076: D6765.diff
	Thu, Nov 14, 8:58 PM

	Unknown Object (File)
	Sun, Nov 10, 12:49 PM

	Unknown Object (File)
	Fri, Nov 8, 8:54 AM

	Unknown Object (File)
	Fri, Nov 1, 10:16 AM

	Unknown Object (File)
	Fri, Nov 1, 10:16 AM

	Unknown Object (File)
	Fri, Nov 1, 10:16 AM

	Unknown Object (File)
	Fri, Nov 1, 10:00 AM

	Unknown Object (File)
	Wed, Oct 30, 1:53 AM

View All 91 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM7b59c4e17e1b: [web] Show @-mentions in pending threads

Summary

For context on the changes here, see ENG-3033

Depends on D6764

Test Plan

Screenshot 2023-02-17 at 11.57.12 AM.png (134×434 px, 12 KB)

(Note that the non-bolded usernames are not members of the parent chat)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 17 2023, 8:55 AM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 17 2023, 8:55 AM

ashoat edited the test plan for this revision. (Show Details)Feb 17 2023, 8:57 AM

Harbormaster completed remote builds in B16583: Diff 22684.Feb 17 2023, 9:16 AM

ashoat requested review of this revision.Feb 17 2023, 9:16 AM

atul accepted this revision.Feb 20 2023, 2:26 PM

This revision is now accepted and ready to land.Feb 20 2023, 2:26 PM

Closed by commit rCOMM7b59c4e17e1b: [web] Show @-mentions in pending threads (authored by ashoat). · Explain WhyFeb 20 2023, 3:14 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7b59c4e17e1b: [web] Show @-mentions in pending threads.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list.react.js

2 lines

markdown/

rules.react.js

25 lines

Diff 22684

View Options

web/chat/chat-message-list.react.js