Page MenuHomePhabricator
Differential D6795

[lib] Make text and media message types read-only
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 10:36 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Mar 17 2025, 4:47 AM
Unknown Object (File)
Mar 17 2025, 4:46 AM
Unknown Object (File)
Mar 13 2025, 4:03 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM07550fb6dc2e: [lib] Make text and media message types read-only
Summary

Was updating these types and figured it would be good to make them read-only.

Test Plan

Flow. Also I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines
lib/
shared/
9 lines
messages/
24 lines
22 lines
types/
messages/
28 lines
28 lines
28 lines

Diff 22832

View Options

keyserver/src/responders/message-responders.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

lib/shared/message-utils.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

lib/shared/messages/multimedia-message-spec.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

lib/shared/messages/text-message-spec.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

lib/types/messages/images.js

  • This file was added.
// @flow
import * as React from 'react';
import type { UserListItem } from 'lib/types/user-types';
import AddMembersItem from './add-members-item.react';
import css from './members-modal.css';
type AddMemberItemGroupProps = {
+header: string,
+userInfos: $ReadOnlyArray<UserListItem>,
+onUserClick: (userID: string) => void,
+usersAdded: $ReadOnlySet<string>,
};
function AddMembersItemGroup(props: AddMemberItemGroupProps): React.Node {
const { userInfos, onUserClick, usersAdded, header } = props;
const sortedUserInfos = React.useMemo(() => {
return [...userInfos].sort((a, b) => a.username.localeCompare(b.username));
}, [userInfos]);
const userInfosComponents = React.useMemo(
() =>
sortedUserInfos.map(userInfo => (
<AddMembersItem
key={userInfo.id}
userInfo={userInfo}
onClick={onUserClick}
userAdded={usersAdded.has(userInfo.id)}
/>
)),
[onUserClick, sortedUserInfos, usersAdded],
);
return (
<>
<div className={css.addMemberItemsGroupHeader}>{header}:</div>
{userInfosComponents}
</>
);
}
export default AddMembersItemGroup;
View Options

lib/types/messages/media.js

Loading...
View Options

lib/types/messages/text.js

Loading...