This is the final diff in the stack. We set sidebarCreation on the client, which makes it so notifs aren't sent by the keyserver.
Depends on D6799
Paths
| Differential D6800 Authored by ashoat on Feb 20 2023, 5:34 PM.
Details Summary This is the final diff in the stack. We set sidebarCreation on the client, which makes it so notifs aren't sent by the keyserver. Depends on D6799 Test Plan I tested this whole stack as follows:
In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptFeb 20 2023, 5:34 PM2023-02-20 17:34:48 (UTC-8) Harbormaster completed remote builds in B16658: Diff 22786.Feb 20 2023, 5:51 PM2023-02-20 17:51:43 (UTC-8) This revision is now accepted and ready to land.Feb 21 2023, 12:10 AM2023-02-21 00:10:42 (UTC-8) Closed by commit rCOMMf51e01ac89c5: [lib][native][web] Set sidebarCreation flag when creating messages that… (authored by ashoat). · Explain WhyFeb 21 2023, 6:19 AM2023-02-21 06:19:54 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 22837 lib/actions/message-actions.js
lib/shared/thread-utils.js
native/input/input-state-container.react.js
web/input/input-state-container.react.js
|