Page MenuHomePhabricator

[keyserver][lib] Pass MessageData to generatesNotifs
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 11:50 PM
Unknown Object (File)
Sat, Dec 28, 11:50 PM
Unknown Object (File)
Sat, Dec 28, 11:49 PM
Unknown Object (File)
Sat, Dec 28, 11:47 PM
Unknown Object (File)
Nov 8 2024, 7:41 AM
Unknown Object (File)
Oct 29 2024, 4:19 PM
Unknown Object (File)
Oct 18 2024, 3:28 AM
Unknown Object (File)
Oct 18 2024, 3:28 AM
Subscribers

Details

Summary

In a later diff, we'll use our new sidebarCreation parameter (introduced earlier in the stack) to affect whether notifs are generated or not.

Depends on D6796

Test Plan

I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable