Page MenuHomePhabricator
Differential D6797

[keyserver][lib] Pass MessageData to generatesNotifs
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 1:28 PM
Unknown Object (File)
Sun, Apr 6, 11:00 AM
Unknown Object (File)
Thu, Apr 3, 7:27 AM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Wed, Apr 2, 3:02 PM
Unknown Object (File)
Mar 17 2025, 3:22 AM
Unknown Object (File)
Mar 17 2025, 3:21 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMc36f710f648c: [keyserver][lib] Pass MessageData to generatesNotifs
Summary

In a later diff, we'll use our new sidebarCreation parameter (introduced earlier in the stack) to affect whether notifs are generated or not.

Depends on D6796

Test Plan

I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
19 lines
lib/
shared/
messages/
1 line
1 line
1 line

Diff 22834

View Options

keyserver/src/creators/message-creator.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/shared/messages/create-sub-thread-message-spec.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/shared/messages/message-spec.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/shared/messages/reaction-message-spec.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };