Page MenuHomePhabricator

[keyserver] Use Platform instead of a DeviceType for sending notifs
ClosedPublic

Authored by michal on Feb 21 2023, 3:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 21, 12:36 PM
Unknown Object (File)
Wed, Feb 21, 10:21 AM
Unknown Object (File)
Wed, Feb 21, 10:21 AM
Unknown Object (File)
Sun, Feb 18, 12:15 AM
Unknown Object (File)
Sat, Feb 17, 11:19 PM
Unknown Object (File)
Sat, Feb 17, 7:57 PM
Unknown Object (File)
Sat, Feb 17, 6:48 PM
Unknown Object (File)
Jan 23 2024, 9:08 PM
Subscribers

Details

Summary

We want to be able to send web notifications but currently send.js is typed using DeviceType which doesn't include web. This diff changes it to use the Platform type and changes some names to fit better. There should be no behaviour changes introduced in this diff.

Test Plan

Create a new account on iOS and check if notifications still work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

One place where the names aren't changed are the Delivery objects which contain a deviceType field that after this diff will contain values from Platform. But it's saved inside the database as json and we would have to support both deviceType field (for older notifications) and platform fields (for newer notifications) when rescinding notifications so I'm not sure if it's worth it.

This revision is now accepted and ready to land.Feb 21 2023, 6:36 AM