Page MenuHomePhabricator

[native] Added terminate() implementation in JS and CommCoreModule
ClosedPublic

Authored by kuba on Feb 22 2023, 2:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 9:01 PM
Unknown Object (File)
Tue, Mar 5, 6:08 AM
Unknown Object (File)
Feb 22 2024, 3:32 AM
Unknown Object (File)
Feb 22 2024, 1:05 AM
Unknown Object (File)
Feb 21 2024, 11:57 PM
Unknown Object (File)
Feb 21 2024, 7:00 PM
Unknown Object (File)
Feb 21 2024, 6:45 PM
Unknown Object (File)
Feb 21 2024, 6:33 PM
Subscribers

Details

Summary

Update of CommCoreModuleSchema.js and associated codegen files, implementation of CommCoreModule::terminate

Test Plan
  1. Compiled the binary code.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba edited the test plan for this revision. (Show Details)
kuba added a reviewer: ashoat.
kuba edited the test plan for this revision. (Show Details)
kuba edited the test plan for this revision. (Show Details)

Removed TODO which was added accidentally

It looks great, but I think this should be two or three diffs:

  1. Update of CommCoreModuleSchema.js and associated codegen files, and implementation of CommCoreModule::terminate
  2. Replacing react-native-exit-app calls with CommCoreModule calls
  3. Delete of react-native-exit-app (potentially could be combined with 2)

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

Resigning so it stays on other reviewers' queues

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

I haven't. So I am going to split this into 2/3 diffs.

Removed added unintentionally "TODO"

kuba retitled this revision from [native] Removed `react-native-exit-app` library to [native] Added terminate() implementation in JS and CommCoreModule.Feb 23 2023, 3:50 AM
kuba edited the summary of this revision. (Show Details)
kuba edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 23 2023, 11:33 AM