[native] Extract device token reducer to lib
ClosedPublic
Actions

Authored by michal on Feb 24 2023, 6:49 AM.

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM16132df36ea3: [native] Extract device token reducer to lib

Summary

We will want to treat the device token similarly on web as on native. This diff extracts the native device token reducer to lib.

Test Plan

Check if device token is correctly saved in redux on new user login.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Feb 24 2023, 6:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 24 2023, 6:49 AM

michal added a child revision: D6815: [keyserver/ web] Handle device_token on web.Feb 24 2023, 6:49 AM

Harbormaster completed remote builds in B16875: Diff 23057.Feb 24 2023, 7:05 AM

michal requested review of this revision.Feb 24 2023, 7:05 AM

ashoat accepted this revision.Feb 24 2023, 3:16 PM

ashoat added inline comments.

native/redux/redux-setup.js
336–339	Should this be moved to `lib/reducers/master-reducer.js`? Or is that done in a later diff?

This revision is now accepted and ready to land.Feb 24 2023, 3:16 PM

Closed by commit rCOMM16132df36ea3: [native] Extract device token reducer to lib (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 1 2023, 12:51 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM16132df36ea3: [native] Extract device token reducer to lib.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

device-token-reducer.js

25 lines

native/

redux/

redux-setup.js

34 lines

Diff 23057

View Options

lib/reducers/device-token-reducer.js