Page MenuHomePhabricator
Differential D6895

[keyserver] Add `signedIdentityKeysBlobValidator` to `logInRequestInputValidator`
ClosedPublic
Actions

Authored by atul on Feb 24 2023, 11:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 9:56 AM
Unknown Object (File)
Sat, Apr 19, 3:34 AM
Unknown Object (File)
Sat, Apr 19, 12:55 AM
Unknown Object (File)
Fri, Apr 18, 8:19 PM
Unknown Object (File)
Thu, Apr 17, 10:07 PM
Unknown Object (File)
Thu, Apr 3, 8:31 AM
Unknown Object (File)
Wed, Apr 2, 3:54 PM
Unknown Object (File)
Wed, Apr 2, 3:54 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM27c3ce790fd9: [keyserver] Add `signedIdentityKeysBlobValidator` to…
Summary

So we can pass signedIdentityKeysBlob to logInResponder endpoint.

Test Plan

Set breakpoint in logInResponder and observed that signedIdentityKeysBlob was as expected and validateInput(...) was successful:

f441f0.png (1×2 px, 423 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6895 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 24 2023, 11:08 PM
atul published this revision for review.Feb 24 2023, 11:08 PM
atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16904: Diff 23095.Feb 24 2023, 11:24 PM
atul added a child revision: D6896: [web] Pass `signedIdentityKeysBlob` to `keyserver` on `siwe_auth`.Feb 24 2023, 11:31 PM
ashoat accepted this revision.Feb 26 2023, 5:39 AM
This revision is now accepted and ready to land.Feb 26 2023, 5:39 AM
atul updated this revision to Diff 23126.Feb 26 2023, 5:38 PM
atul edited the summary of this revision. (Show Details)

rebase + land

This revision was landed with ongoing or failed builds.Feb 26 2023, 5:45 PM
Closed by commit rCOMM27c3ce790fd9: [keyserver] Add `signedIdentityKeysBlobValidator` to… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM27c3ce790fd9: [keyserver] Add `signedIdentityKeysBlobValidator` to….
Harbormaster completed remote builds in B16920: Diff 23126.Feb 26 2023, 5:54 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
6 lines
lib/
actions/
3 lines

Diff 23126

View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

lib/actions/user-actions.js

Loading...