[keyserver] Introduce `OLMUtility` type
ClosedPublic
Actions

Authored by atul on Feb 27 2023, 1:39 PM.

Details

Reviewers

ashoat
tomek
marcin
varun

Commits

rCOMM4895ba2d1a3e: [keyserver] Introduce `OLMUtility` type

Summary

The getOLMUtility() function we introduce is going to need to return Promise<OLMUtility>.

Based on the TypeScript typedefs:

Test Plan

Will be tested implicitly by subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 27 2023, 1:39 PM

atul edited the summary of this revision. (Show Details)Feb 27 2023, 1:39 PM

The index.d.ts is pretty short (130 ~~characters~~ lines), might be worth typing the library since I imagine we're going to use it quite a bit going forward. ~~Not going to create a task at the moment, I think it'll be clear when we need to do it.~~

https://linear.app/comm/issue/ENG-3138/type-olm-library-for-flow

atul published this revision for review.Feb 27 2023, 1:42 PM

ashoat accepted this revision.Feb 27 2023, 1:45 PM

This revision is now accepted and ready to land.Feb 27 2023, 1:45 PM

Harbormaster completed remote builds in B16956: Diff 23177.Feb 27 2023, 1:55 PM

rebase + land

This revision was landed with ongoing or failed builds.Feb 27 2023, 3:16 PM

Closed by commit rCOMM4895ba2d1a3e: [keyserver] Introduce `OLMUtility` type (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4895ba2d1a3e: [keyserver] Introduce `OLMUtility` type.

Harbormaster completed remote builds in B16964: Diff 23186.Feb 27 2023, 3:31 PM