Page MenuHomePhabricator

[desktop CI] Inherit secrets in github release workflow
ClosedPublic

Authored by michal on Mar 2 2023, 7:32 AM.
Tags
None
Referenced Files
F3379267: D6927.diff
Wed, Nov 27, 3:29 PM
Unknown Object (File)
Sun, Nov 10, 7:01 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 10:33 AM
Unknown Object (File)
Fri, Nov 8, 10:28 AM
Unknown Object (File)
Fri, Nov 8, 10:26 AM
Unknown Object (File)
Fri, Nov 8, 9:51 AM
Subscribers

Details

Summary

We are calling the windows_ci and macos_ci workflows from the desktop_release workflow but the secrets required for building aren't passed automatically. We can use secrets: inherit to pass them to the workflows we are calling.

Documentation about [secrets: inherit](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsecretsinherit).

Test Plan

Tested on a fork

Diff Detail

Repository
rCOMM Comm
Branch
michal/fix-desktop-release
Lint
No Lint Coverage
Unit
No Test Coverage