Page MenuHomePhabricator

[native] Move CommSecureStore::get to main thread to avoid JNI crash
ClosedPublic

Authored by ashoat on Mar 6 2023, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 8:43 PM
Unknown Object (File)
Sat, Dec 21, 7:26 AM
Unknown Object (File)
Fri, Dec 20, 5:15 PM
Unknown Object (File)
Thu, Dec 19, 12:57 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:11 AM
Unknown Object (File)
Sat, Dec 14, 8:10 AM
Subscribers

Details

Summary

This is option 2 from this Linear comment.

Depends on D6957

Test Plan

Test that the error goes away in favor of another see (see Linear)

Also need to test this on iOS before landing to make sure it doesn't break that, but should be okay

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
834–835 ↗(On Diff #23469)

Verified locally that this was a valid way to split string across multiple lines.. don't think I've seen his before

This revision is now accepted and ready to land.Mar 6 2023, 12:37 PM