[native] Replace LayoutAnimation for driving fixed Tooltip animation
ClosedPublic
Actions

Authored by ashoat on Mar 8 2023, 1:25 PM.

Details

Reviewers

ginsu

Commits

rCOMM5da7d4f027af: [native] Replace LayoutAnimation for driving fixed Tooltip animation

Summary

Driving this separately via LayoutAnimation looks janky. This diff makes us drive it using the same position that the rest of the animation is driven with.

Depends on D7014

Test Plan

Flow, and testing the reaction popover animation on iOS and Android release builds, including opening the emoji keyboard

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/tooltip-animation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 8 2023, 1:25 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 8 2023, 1:25 PM

Accidentally included something

Harbormaster failed remote builds in B17202: Diff 23555!Mar 8 2023, 1:44 PM

Harbormaster completed remote builds in B17203: Diff 23556.Mar 8 2023, 1:47 PM

ashoat requested review of this revision.Mar 8 2023, 1:47 PM

ginsu accepted this revision.Mar 8 2023, 8:44 PM

This revision is now accepted and ready to land.Mar 8 2023, 8:44 PM

Closed by commit rCOMM5da7d4f027af: [native] Replace LayoutAnimation for driving fixed Tooltip animation (authored by ashoat). · Explain WhyMar 8 2023, 8:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5da7d4f027af: [native] Replace LayoutAnimation for driving fixed Tooltip animation.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

23 lines

Diff 23556

View Options

native/tooltip/tooltip.react.js

[native] Replace LayoutAnimation for driving fixed Tooltip animationClosedPublicActions