[native] Implement `getSignedIdentityKeysBlob(...)` for `native`
ClosedPublic
Actions

Authored by atul on Mar 10 2023, 4:57 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMc6ac8fec2856: [native] Implement `getSignedIdentityKeysBlob(...)` for `native`

Summary

In this diff we implement getSignedIdentityKeysBlob(...) and pass it to nativeGetClientResponsesSelector...) so we can call it from within the function created by getClientResponsesSelector(...) if we need to handle serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB.

Depends on D7034

Test Plan

See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is properly constructed and received by keyserver.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 10 2023, 4:57 PM

atul published this revision for review.Mar 10 2023, 4:58 PM

Harbormaster completed remote builds in B17244: Diff 23617.Mar 10 2023, 5:12 PM

atul added a child revision: D7036: [web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`.Mar 10 2023, 5:32 PM

ashoat accepted this revision.Mar 11 2023, 5:26 AM

This revision is now accepted and ready to land.Mar 11 2023, 5:26 AM

include call to commCoreModule.initializeCryptoAccount(...)

native/selectors/socket-selectors.js
56 ↗	(On Diff #23627)	I made sure calls to `initializeCryptoAccount(...)` were "idempotent." We really should be handling this on app launch or something?