[web] Pull `signedIdentityKeysBlobSelector` out of `getSignedIdentityKeysBlobSelector`
ClosedPublic
Actions

Authored by atul on Mar 11 2023, 2:24 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMdf61c23a2af5: [web] Pull `signedIdentityKeysBlobSelector` out of…

Summary

We extract signedIdentityKeysBlobSelector out from getSignedIdentityKeysBlobSelector in this refactor so we can reuse it in TraditionalLoginForm() and SIWELoginForm().

Depends on D7036

Test Plan

Will be tested in subsequent diffs where signedIdentityKeysBlobSelector is consumed from TraditionalLoginForm() and SIWELoginForm().

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 11 2023, 2:24 AM

atul published this revision for review.Mar 11 2023, 2:24 AM

Harbormaster completed remote builds in B17246: Diff 23619.Mar 11 2023, 2:40 AM

ashoat accepted this revision.Mar 11 2023, 2:12 PM

This revision is now accepted and ready to land.Mar 11 2023, 2:12 PM

Closed by commit rCOMMdf61c23a2af5: [web] Pull `signedIdentityKeysBlobSelector` out of…. · Explain WhyMar 11 2023, 11:59 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMdf61c23a2af5: [web] Pull `signedIdentityKeysBlobSelector` out of….

Revision Contents
Changeset List

Path

Size

web/

selectors/

socket-selectors.js

16 lines

Diff 23632

View Options

web/selectors/socket-selectors.js

[web] Pull `signedIdentityKeysBlobSelector` out of `getSignedIdentityKeysBlobSelector`ClosedPublicActions