Page MenuHomePhabricator

[web] Introduce `getSignedIdentityKeysBlobSelector(...)` to generate `getSignedIdentityKeysBlob(...)`
ClosedPublic

Authored by atul on Mar 10 2023, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 15, 12:00 AM
Unknown Object (File)
Mon, Apr 15, 12:00 AM
Unknown Object (File)
Mon, Apr 15, 12:00 AM
Unknown Object (File)
Mon, Apr 15, 12:00 AM
Unknown Object (File)
Sun, Apr 14, 11:49 PM
Unknown Object (File)
Mar 7 2024, 3:56 AM
Unknown Object (File)
Mar 5 2024, 11:08 PM
Unknown Object (File)
Mar 5 2024, 11:08 PM
Subscribers
None

Details

Summary

Unlike native, where in D7035 getSignedIdentityKeysBlob(...) makes a JSI call, for web we need to construct signedIdentityKeysBlob from the Redux CryptoStore. We generate getSignedIdentityKeysBlob(...) from the new getSignedIdentityKeysBlobSelector and pass it to webGetClientResponsesSelector where it will be passed to the function generated by getClientResponsesSelector (it's a lot of creating a function within a thing that creates a function within a thing that creates a function...)

Now that we have this selector, we can conveniently reuse it in TraditionalLoginForm() and SIWELoginForm(). I'll make that refactor in a subsequent diff.


Depends on D7035

Test Plan

See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is correctly constructed and received by keyserver:

82f94e.png (1×3 px, 742 KB)

Will also be tested in the diff where we consume getSignedIdentityKeysBlobSelector in TraditionalLoginForm() and SIWELoginForm().

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Mar 10 2023, 5:33 PM
This revision is now accepted and ready to land.Mar 11 2023, 5:32 AM

See if ClientClientResponse for serverRequestTypes.SIGNED_IDENTITY_KEYS_BLOB is correctly constructed and received by keyserver.

82f94e.png (1×3 px, 742 KB)

This revision was landed with ongoing or failed builds.Mar 11 2023, 3:49 PM
This revision was automatically updated to reflect the committed changes.