Differential D7045

[lib] Add test of ENS avatar set to IPFS URI which holds a JPEG
ClosedPublic
Actions

Authored by ashoat on Mar 11 2023, 4:26 PM.

Tags

None

Referenced Files

	F5891486: D7045.id23639.diff
	Thu, Apr 17, 7:28 AM

	Unknown Object (File)
	Feb 25 2025, 4:40 AM

	Unknown Object (File)
	Feb 25 2025, 4:40 AM

	Unknown Object (File)
	Feb 25 2025, 4:40 AM

	Unknown Object (File)
	Feb 24 2025, 12:40 PM

	Unknown Object (File)
	Feb 19 2025, 12:10 PM

	Unknown Object (File)
	Feb 16 2025, 8:55 AM

	Unknown Object (File)
	Feb 16 2025, 8:55 AM

Subscribers

Details

Reviewers

Commits

rCOMM62496db0954d: [lib] Add test of ENS avatar set to IPFS URI which holds a JPEG

Summary

Depends on D7044

Test Plan

Test plan described here, implemented via unit tests in this and surrounding diffs
Tested SVGs in React Native as noted here

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 11 2023, 4:26 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 11 2023, 4:26 PM

ashoat added a child revision: D7046: [lib] Add test of ENS avatar set to NFT which is an SVG data URI.Mar 11 2023, 4:26 PM

Harbormaster completed remote builds in B17259: Diff 23639.Mar 11 2023, 4:44 PM

ashoat requested review of this revision.Mar 11 2023, 4:44 PM

atul accepted this revision.Mar 11 2023, 9:16 PM

This revision is now accepted and ready to land.Mar 11 2023, 9:16 PM

Closed by commit rCOMM62496db0954d: [lib] Add test of ENS avatar set to IPFS URI which holds a JPEG (authored by ashoat). · Explain WhyMar 12 2023, 12:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM62496db0954d: [lib] Add test of ENS avatar set to IPFS URI which holds a JPEG.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.test.js

13 lines

Diff 23647

lib/utils/ens-cache.test.js

	Show All 13 Lines
	target_link_libraries(comm-client			target_link_libraries(comm-client
	comm-modules-native			comm-modules-native
	)			)

	target_link_libraries(comm-cryptotools			target_link_libraries(comm-cryptotools
	comm-tools			comm-tools
	comm-databasemanagers			comm-databasemanagers
	)			)

				target_link_libraries(comm-modules-internal
				comm-tools
				comm-client
				)

				target_link_libraries(comm-modules-native
				comm-client
				comm-cryptotools
				comm-databasemanagers
				comm-tools
				)

				target_link_libraries(comm-modules-persistentstorage
				comm-databasemanagers
				comm-client
				)