Paths

Table of Contentst

Differential D7039

[lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress
ClosedPublic
Actions

Authored by ashoat on Mar 11 2023, 4:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 8:44 PM

	Unknown Object (File)
	Tue, May 7, 8:44 PM

	Unknown Object (File)
	Thu, May 2, 2:39 AM

	Unknown Object (File)
	Mar 31 2024, 1:20 PM

	Unknown Object (File)
	Mar 31 2024, 1:19 PM

	Unknown Object (File)
	Mar 31 2024, 1:17 PM

	Unknown Object (File)
	Mar 9 2024, 3:17 PM

	Unknown Object (File)
	Mar 8 2024, 5:31 PM

View All 45 Files

Subscribers

Details

Reviewers

Commits

rCOMMf0c55c5600d7: [lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress

Summary

In a following diff, I'm going to introduce getCachedAvatarEntryForAddress, so I'm clarifying this method's name now.

For consistency, also renamed getCachedEntryForName to this.getCachedAddressEntryForName.

Test Plan

Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 11 2023, 4:22 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 11 2023, 4:22 PM

ashoat added a child revision: D7040: [lib] Clarify query type in throwOnTimeout.Mar 11 2023, 4:23 PM

Harbormaster completed remote builds in B17253: Diff 23633.Mar 11 2023, 4:38 PM

ashoat requested review of this revision.Mar 11 2023, 4:38 PM

atul accepted this revision.Mar 11 2023, 8:03 PM

This revision is now accepted and ready to land.Mar 11 2023, 8:03 PM

Closed by commit rCOMMf0c55c5600d7: [lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress (authored by ashoat). · Explain WhyMar 12 2023, 12:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf0c55c5600d7: [lib] Rename getCachedEntryForAddress to getCachedNameEntryForAddress.

Revision Contents
Changeset List

Path

Size

lib/

utils/

12 lines

Diff 23641

lib/utils/ens-cache.js

Loading...