[lib] Add basic tests for getAvatarURIForAddress
ClosedPublic
Actions

Authored by ashoat on Mar 11 2023, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 7, 8:44 PM

	Unknown Object (File)
	Tue, May 7, 8:44 PM

	Unknown Object (File)
	Thu, May 2, 2:39 AM

	Unknown Object (File)
	Mar 31 2024, 1:20 PM

	Unknown Object (File)
	Mar 31 2024, 1:20 PM

	Unknown Object (File)
	Mar 31 2024, 1:17 PM

	Unknown Object (File)
	Mar 8 2024, 6:47 PM

	Unknown Object (File)
	Mar 7 2024, 7:24 AM

View All 46 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM7112c9976ee9: [lib] Add basic tests for getAvatarURIForAddress

Summary

Depends on D7042

Test Plan

Test plan described here, implemented via unit tests in this and following diffs
Tested SVGs in React Native as noted here

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 11 2023, 4:25 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 11 2023, 4:25 PM

ashoat added a child revision: D7044: [lib] Add tests for caching behavior of getAvatarURIForAddress.Mar 11 2023, 4:26 PM

Harbormaster completed remote builds in B17257: Diff 23637.Mar 11 2023, 4:40 PM

ashoat requested review of this revision.Mar 11 2023, 4:40 PM

Thanks for including unit tests

This revision is now accepted and ready to land.Mar 11 2023, 8:58 PM

Closed by commit rCOMM7112c9976ee9: [lib] Add basic tests for getAvatarURIForAddress (authored by ashoat). · Explain WhyMar 12 2023, 12:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7112c9976ee9: [lib] Add basic tests for getAvatarURIForAddress.

Revision Contents
Changeset List

Path

Size

lib/

utils/

ens-cache.test.js

29 lines

Diff 23645

View Options

lib/utils/ens-cache.test.js

[lib] Add basic tests for getAvatarURIForAddressClosedPublicActions