[native] Remove network.json fallbacks
ClosedPublic
Actions

Authored by bartek on Mar 12 2023, 11:36 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM8962253e8bd9: [native] Remove network.json fallbacks

Summary

Autodetected IP has been staying with us for some time without issues, time to finally remove network.json.

Steps made:

Removed native/facts/network.json references as described in ENG-2742. Deleting it from .gitignore will force people still having this file to remove it
Reworked the warning as described in ENG-2743.

Test Plan

Ran yarn dev and opened mobile app. Ensured that it keeps working as expected.
Manually replaced ip.v4.sync() with undefined and ensured that:
- The warning is displayed once in Metro
- The warning is displayed once in-app
When the COMM_NAT_DEV_HOSTNAME env variable is set, the above warnings disappear

Repository

rCOMM Comm

Branch

barthap/delete-network-json

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

yarn start -> yarn dev

bartek published this revision for review.Mar 13 2023, 12:12 AM

ashoat added inline comments.

native/utils/dev-hostname.js
21–23	Why do we need both this notice as well as the `native/app.config.js`? Does one show up during compile time, and the other during app runtime?

This revision is now accepted and ready to land.Mar 13 2023, 9:36 AM

native/utils/dev-hostname.js
21–23	One shows up in the console when Metro starts, this one appears during runtime when neither autodetection nor env var are set. I'd prefer to leave only the Metro one, but it is easy to miss (maybe it could be colored or sth, but I'd need to install `chalk` dependency in such case).