Page MenuHomePhabricator

Use initial notifications from queue rather than from launch options
ClosedPublic

Authored by marcin on Mar 13 2023, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 23, 8:44 AM
Unknown Object (File)
Fri, Feb 23, 7:46 AM
Unknown Object (File)
Fri, Feb 23, 6:05 AM
Unknown Object (File)
Fri, Feb 23, 5:45 AM
Unknown Object (File)
Fri, Feb 23, 1:23 AM
Unknown Object (File)
Wed, Feb 21, 12:39 PM
Unknown Object (File)
Wed, Feb 7, 3:44 AM
Unknown Object (File)
Wed, Feb 7, 3:44 AM
Subscribers

Details

Summary

This differential is a fix for the iOS part of this issue: https://linear.app/comm/issue/ENG-3269/app-erroneously-opens-to-chats-at-random-times. Initially when app was entering the foreground in respone to tapping the notif we were querying
initial launch options for notification that launched the app (no the one that was tapped, but the one that booted the app). In case there was any we would navigate user to the thread corresponding to this notification. This resulted in erroneous navigation since the thread correpsonding to
the lastest notif that foregrounded (not booted!) the app might had been different.

Test Plan

Build the app and check that tapping notification always navigates us to the correct thread.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good! Thanks for linking to the Linear issue and jotting down detailed notes there.

This revision is now accepted and ready to land.Mar 13 2023, 5:03 PM

Why hasn't this been landed? It's an urgent issue and the diff was accepted on Monday...

Why hasn't this been landed? It's an urgent issue and the diff was accepted on Monday...

I will make sure to land differentials of this kind more efficiently in future.