Page MenuHomePhabricator

[landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin
ClosedPublic

Authored by ashoat on Mar 14 2023, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 21, 7:33 PM
Unknown Object (File)
Sun, Feb 18, 9:52 PM
Unknown Object (File)
Sun, Feb 18, 5:33 PM
Unknown Object (File)
Sun, Feb 18, 1:36 PM
Unknown Object (File)
Sun, Feb 18, 12:17 PM
Unknown Object (File)
Wed, Feb 7, 9:44 PM
Unknown Object (File)
Wed, Feb 7, 9:44 PM
Unknown Object (File)
Mon, Feb 5, 12:29 AM
Subscribers

Details

Summary

This addresses ENG-3328. assets-webpack-plugin has this problem and webpack-manifest-plugin is officially recommended by Webpack.

Old JSON file looked like this:

{"browser":{"css":"prod.41af96d9c587.build.css","js":"prod.8860cda0687b.build.js"},"":{"wasm":"olm.983876380b11.wasm"}}

New JSON file looks like this:

{
  "browser.css": "prod.41af96d9c587.build.css",
  "browser.js": "prod.3bf3c62a7a70.build.js",
  "olm.wasm": "olm.983876380b11.wasm"
}
Test Plan

I ran keyserver / web / landing in prod mode and confirmed that JS, CSS, and olm.wasm all successfully loaded

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

landing/webpack.config.cjs
50 ↗(On Diff #23743)

This replaces removeFullPathAutoPrefix. Without this, all of the filenames are prefixed with auto/ for some reason. From scouring GitHub, it seems to have something to do with this, but I didn't really investigate it too far.

This revision is now accepted and ready to land.Mar 16 2023, 2:59 AM