Paths

Table of Contentst

Differential D7072

[landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin
ClosedPublic
Actions

Authored by ashoat on Mar 14 2023, 4:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 2, 2:23 AM

	Unknown Object (File)
	Tue, Dec 31, 9:18 AM

	Unknown Object (File)
	Sun, Dec 29, 7:47 PM

	Unknown Object (File)
	Sun, Dec 29, 7:47 PM

	Unknown Object (File)
	Sun, Dec 29, 7:40 PM

	Unknown Object (File)
	Sat, Dec 21, 12:10 PM

	Unknown Object (File)
	Dec 8 2024, 3:39 AM

	Unknown Object (File)
	Dec 6 2024, 9:47 PM

Subscribers

Details

Reviewers

atul
kamil
michal

Commits

rCOMM731fe43071a3: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin

Summary

This addresses ENG-3328. assets-webpack-plugin has this problem and webpack-manifest-plugin is officially recommended by Webpack.

Old JSON file looked like this:

{"browser":{"css":"prod.41af96d9c587.build.css","js":"prod.8860cda0687b.build.js"},"":{"wasm":"olm.983876380b11.wasm"}}

New JSON file looks like this:

{
  "browser.css": "prod.41af96d9c587.build.css",
  "browser.js": "prod.3bf3c62a7a70.build.js",
  "olm.wasm": "olm.983876380b11.wasm"
}

Test Plan

I ran keyserver / web / landing in prod mode and confirmed that JS, CSS, and olm.wasm all successfully loaded

Diff Detail

Repository

Branch

ashoat/manifest

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 14 2023, 4:07 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 14 2023, 4:07 PM

ashoat added inline comments.Mar 14 2023, 4:10 PM

landing/webpack.config.cjs
50	This replaces `removeFullPathAutoPrefix`. Without this, all of the filenames are prefixed with `auto/` for some reason. From scouring GitHub, it seems to have something to do with this, but I didn't really investigate it too far.

Harbormaster completed remote builds in B17336: Diff 23743.Mar 14 2023, 4:23 PM

ashoat requested review of this revision.Mar 14 2023, 4:23 PM

ashoat added reviewers: kamil, michal.Mar 14 2023, 6:30 PM

Looks good to me

This revision is now accepted and ready to land.Mar 16 2023, 2:59 AM

Closed by commit rCOMM731fe43071a3: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin (authored by ashoat). · Explain WhyMar 16 2023, 3:59 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM731fe43071a3: [landing][web] Migrate from assets-webpack-plugin to webpack-manifest-plugin.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

landing-handler.js

13 lines

website-responders.js

12 lines

landing/

4 lines

webpack.config.cjs

8 lines

web/

4 lines

webpack.config.cjs

8 lines

32 lines

Diff 23743

keyserver/src/responders/landing-handler.js

Loading...

keyserver/src/responders/website-responders.js

Loading...

landing/package.json

Loading...

landing/webpack.config.cjs

Loading...

web/package.json

Loading...

web/webpack.config.cjs

Loading...

yarn.lock

Loading...