We want to send updateBadgeCount notifs to macOS. This works exactly the same as the iOS version, just replaced the ios with macos.
Details
Details
- Open the desktop app
- Send a message from another user -> desktop app gets a notification and macOS dock badge updates
- Read the message on another device -> the dock badge disappears, in the logs we can check that the we got unreadBadgeCount notif
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| desktop/src/push-notifications.js | ||
|---|---|---|
| 31–33 | This is no longer true when sending updateBadgeCount notifications. This will still show run on older clients, but it's just a console warning and only visible if you run the desktop app through a terminal. | |
Comment Actions
This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!
Separately, there are still two only for Flow lines in send.js – would be good to get rid of all of them!
Comment Actions
This diff seems to call getAPNsNotificationTopic with two parameters, but the version of that function in master only takes one parameter. Can you please update this diff's dependencies so I can see the rest of your stack? Please always set diff dependencies!
There's no stack for this diff, I'm calling getAPNsNotificationTopic with one argument, it's just an object with two fields.
Comment Actions
Actually remove the remaining "only for flow" lines, not sure why this didn't commit before...