Page MenuHomePhabricator

[server] Update AASA file so that we prove to iOS that the domain belongs to us
ClosedPublic

Authored by tomek on Mar 22 2023, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 5 2024, 11:47 PM
Unknown Object (File)
Mar 5 2024, 11:47 PM
Unknown Object (File)
Mar 5 2024, 11:46 PM
Unknown Object (File)
Mar 5 2024, 11:14 PM
Unknown Object (File)
Feb 27 2024, 10:43 AM
Unknown Object (File)
Feb 27 2024, 10:43 AM
Unknown Object (File)
Feb 27 2024, 10:43 AM
Unknown Object (File)
Feb 27 2024, 10:40 AM
Subscribers

Details

Summary

I had to remove trailing commas because otherwise JSON validation fails (according to https://jsonlint.com/). According to https://developer.apple.com/documentation/xcode/supporting-associated-domains the identifier consists of <Application Identifier Prefix>.<Bundle Identifier>. Expo documentation https://docs.expo.dev/guides/deep-linking/ explains that the prefix is just a Team ID which can be found at https://developer.apple.com/account. It also informs that as of iOS 13 Apple introduced a new format (with appIDs instead of appID) and suggests to use both, but the new one first.

Test Plan

I've checked if our current AASA file is served correctly by checking what https://web.comm.app/.well-known/apple-app-site-association returns. The current version from the server fails the validation at https://branch.io/resources/aasa-validator/ because the JSON isn't properly formatted. I've checked the new version by using the recommended JSON validator. Testing if the new configuration allows deep linking will be performed when the file is deployed on the server.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/.well-known/apple-app-site-association
2–4 ↗(On Diff #23994)

I wasn't sure about this. It was outdated so I guess we weren't using it, and probably can be safely deleted.

tomek requested review of this revision.Mar 22 2023, 7:36 AM

The new ID looks correct

IIRC @ashoat did some linking long time ago so there are leftovers across the codebase (e.g. here)

This revision is now accepted and ready to land.Mar 22 2023, 9:49 AM

The new ID looks correct

IIRC @ashoat did some linking long time ago so there are leftovers across the codebase (e.g. here)

Thanks for pointing this out - I've seen that comment and will need to update that code. I'll do that in a diff that covers the client part of the configuration.