[lib] Update `CurrentUserInfo` on `updateUserAvatarActionTypes.success`
ClosedPublic
Actions

Authored by atul on Mar 23 2023, 10:27 AM.

Details

Reviewers

ashoat
ginsu

Commits

Summary

We want to update CurrentUserInfo in Redux on successful updateUserAvatarActionTypes.success.

Test Plan

Send { type: 'remove' } to update_user_avatar and observe that the avatar is unset in Redux:

const emojiUpdateRequest = {
  type: 'emoji',
  emoji: '👍',
  color: '4b87aa',
};

to update_user_avatar and observe that CurrentUserInfo is updated as expected:

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

atul edited the test plan for this revision. (Show Details)Mar 23 2023, 10:28 AM

atul published this revision for review.Mar 23 2023, 10:33 AM

atul added inline comments.

lib/reducers/user-reducer.js
97–101	This condition doesn't "smell right," but it's the only approach I could think of that made `flow` happy. Should I be doing this differently? All the other action handlers in `reduceCurrentUserInfo` update `CurrentUserInfo` "atomically." As in they either keep or replace `CurrentUserInfo` "in one go." None of them modify a single field of the object at a time. The `state` check is to determine whether the existing `?CurrentUserInfo` is truthy, and the `!state.anonymous` check is to ensure that the existing `?CurrentUserInfo` is a `?LoggedInUserInfo` (`LoggedOutUserInfo` doesn't have an `avatar` field).