Page MenuHomePhabricator

Allow while(true) in the JS codebase
ClosedPublic

Authored by ashoat on Mar 24 2023, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 7:27 PM
Unknown Object (File)
Mon, Mar 17, 7:10 PM
Unknown Object (File)
Mon, Mar 3, 4:40 PM
Unknown Object (File)
Mon, Mar 3, 4:40 PM
Unknown Object (File)
Thu, Feb 27, 5:40 PM
Unknown Object (File)
Thu, Feb 27, 5:39 PM
Subscribers
None

Details

Summary

I find that it's sometimes better for readability for the condition of a loop to be determined by a break call inside the body of the loop. More context here.

Test Plan

I edited a file and added a while (true) { break; } line. Before this diff it causes an ESLint error, but afterwards it didn't

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable