Page MenuHomePhabricator

Allow while(true) in the JS codebase
ClosedPublic

Authored by ashoat on Mar 24 2023, 12:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:04 PM
Unknown Object (File)
Fri, Nov 8, 8:34 AM
Unknown Object (File)
Wed, Nov 6, 11:02 PM
Unknown Object (File)
Mon, Oct 28, 1:44 AM
Unknown Object (File)
Sat, Oct 26, 6:30 PM
Unknown Object (File)
Sep 28 2024, 6:29 AM
Unknown Object (File)
Sep 28 2024, 6:29 AM
Unknown Object (File)
Sep 28 2024, 6:29 AM
Subscribers
None

Details

Summary

I find that it's sometimes better for readability for the condition of a loop to be determined by a break call inside the body of the loop. More context here.

Test Plan

I edited a file and added a while (true) { break; } line. Before this diff it causes an ESLint error, but afterwards it didn't

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable