Page MenuHomePhabricator

Allow while(true) in the JS codebase
ClosedPublic

Authored by ashoat on Mar 24 2023, 12:10 PM.
Tags
None
Referenced Files
F1431576: D7173.id24096.diff
Thu, Mar 28, 3:03 AM
F1431575: D7173.id24090.diff
Thu, Mar 28, 3:03 AM
F1431512: D7173.id.diff
Thu, Mar 28, 3:02 AM
F1431444: D7173.diff
Thu, Mar 28, 2:53 AM
Unknown Object (File)
Feb 25 2024, 6:15 PM
Unknown Object (File)
Feb 7 2024, 8:12 AM
Unknown Object (File)
Feb 7 2024, 8:12 AM
Unknown Object (File)
Feb 7 2024, 8:06 AM
Subscribers
None

Details

Summary

I find that it's sometimes better for readability for the condition of a loop to be determined by a break call inside the body of the loop. More context here.

Test Plan

I edited a file and added a while (true) { break; } line. Before this diff it causes an ESLint error, but afterwards it didn't

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable