Page MenuHomePhabricator
Differential D7179

[keyserver] Convert user ID to VARCHAR in MariaDB
ClosedPublic
Actions

Authored by ashoat on Mar 26 2023, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 25, 5:27 PM
Unknown Object (File)
Fri, May 10, 5:28 PM
Unknown Object (File)
Apr 14 2024, 7:28 PM
Unknown Object (File)
Apr 14 2024, 7:28 PM
Unknown Object (File)
Apr 14 2024, 7:27 PM
Unknown Object (File)
Apr 14 2024, 7:25 PM
Unknown Object (File)
Apr 3 2024, 4:00 AM
Unknown Object (File)
Mar 5 2024, 11:52 PM
View All 53 Files
Subscribers
None

Details

Reviewers
atul
• jon
tomek
Commits
rCOMMb16cebb0a1b5: [keyserver] Convert user ID to VARCHAR in MariaDB
Summary

Identity service is going to own user IDs going forward, and they are no longer going to be exclusively numeric.

To pave the way for this, we're converting all user ID columns to VARCHAR(255) in the latin1 charset.

Linear task: https://linear.app/comm/issue/ENG-3279/migrate-mariadb-user-ids-to-varchar-type

Test Plan
  1. I tested by migrating an existing database and creating a new one
  2. I tested creating a new user
  3. I tested logging in an existing user
  4. I tested sending messages
  5. I tested sending / accepting a friend request
  6. I tested unfriending
  7. I tested blocking / unblocking

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 26 2023, 7:04 PM
ashoat edited the summary of this revision. (Show Details)Mar 26 2023, 7:07 PM
Harbormaster completed remote builds in B17650: Diff 24155.Mar 26 2023, 7:20 PM
ashoat requested review of this revision.Mar 26 2023, 7:20 PM
tomek accepted this revision.Mar 27 2023, 2:20 AM
tomek added inline comments.
keyserver/src/database/setup-db.js
67 ↗(On Diff #24155)

I wasn't sure if this change would work correctly, as an id is also stored in ids table as a number, but the test plan seems to cover most of the things that might break.

This revision is now accepted and ready to land.Mar 27 2023, 2:20 AM
ashoat added inline comments.Mar 27 2023, 2:01 PM
keyserver/src/database/setup-db.js
67 ↗(On Diff #24155)

For users registered via the new identity service mechanism, we won't be using the ids table at all. We'll only use the ids table for local AUTO_INCREMENT keyserver IDs

Closed by commit rCOMMb16cebb0a1b5: [keyserver] Convert user ID to VARCHAR in MariaDB (authored by ashoat). · Explain WhyMar 27 2023, 4:49 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb16cebb0a1b5: [keyserver] Convert user ID to VARCHAR in MariaDB.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
48 lines
40 lines

Diff 24251

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...