Differential D7214

[native] introduce RustCallback
ClosedPublic
Actions

Authored by varun on Mar 27 2023, 8:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 26, 4:17 PM

	Unknown Object (File)
	Wed, Jun 26, 3:29 PM

	Unknown Object (File)
	Tue, Jun 25, 12:37 PM

	Unknown Object (File)
	Tue, Jun 25, 12:37 PM

	Unknown Object (File)
	Tue, Jun 25, 12:36 PM

	Unknown Object (File)
	Tue, Jun 25, 12:32 PM

	Unknown Object (File)
	Wed, Jun 19, 11:35 PM

	Unknown Object (File)
	Wed, Jun 12, 5:43 PM

View All 63 Files

Subscribers

Details

Reviewers

ashoat
• jon

Commits

rCOMMbdb8e2db3913: [native] introduce RustCallback

Summary

we introduce a generic C++ callback function to be called from Rust

note that this function is only used when the js return type is Promise<string>

we'll have to add similar functions to RustCallback for other return types
luckily we really only ever return strings from rust...

Test Plan

this gets tested in the next diff in stack

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 27 2023, 8:54 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 27 2023, 8:54 PM

varun added a parent revision: D7213: [services][identity] implement generate_nonce RPC in new client_service..Mar 27 2023, 9:01 PM

varun added a child revision: D7215: [native] make generateNonce callable from js.

Harbormaster completed remote builds in B17722: Diff 24257.Mar 27 2023, 9:09 PM

varun requested review of this revision.Mar 27 2023, 9:09 PM

varun added inline comments.Mar 27 2023, 9:17 PM

native/android/app/build.gradle
382–401	we build the native_rust_library in a gradle preBuild step because RustCallback includes generated files that need to exist before CMake attempts to build the binary
native/native_rust_library/RustCallback.cpp
1	i'll remove this random extra line
3–5	couldn't figure out how to make these absolute paths without xcode complaining..

ashoat accepted this revision.Mar 28 2023, 5:36 AM

ashoat added 1 blocking reviewer(s): • jon.

ashoat added inline comments.

native/android/app/build.gradle
382–401	Does this mean we build it "twice"? Is it cached the second time? Do we build it for every architecture here?

I'm not able to comment on gradle code, but I couldn't find a better way to do this using just cmake + corrosion + cxxbridge

native/native_rust_library/RustCallback.cpp
3–5	I'll do it some time later https://linear.app/comm/issue/ENG-3419

This revision is now accepted and ready to land.Mar 28 2023, 8:25 AM

varun added inline comments.Mar 28 2023, 9:44 AM

native/android/app/build.gradle
382–401	yeah we build it twice, but it is cached the second time. we only build for a single arch here since we just need the generated C++ files

Closed by commit rCOMMbdb8e2db3913: [native] introduce RustCallback (authored by varun). · Explain WhyMar 28 2023, 9:55 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMbdb8e2db3913: [native] introduce RustCallback.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

2 lines

22 lines

ios/

Comm.xcodeproj/

project.pbxproj

12 lines

native_rust_library/

9 lines

RustCallback.cpp

27 lines

shared/

cmake/

corrosion-cxx.cmake

2 lines

Diff 24257

native/android/app/CMakeLists.txt

Loading...

native/android/app/build.gradle

Loading...

native/ios/Comm.xcodeproj/project.pbxproj

Loading...

native/native_rust_library/RustCallback.h

Loading...

native/native_rust_library/RustCallback.cpp

Loading...

shared/cmake/corrosion-cxx.cmake

Loading...