This endpoint won't be accessed when the app is installed - opening it on a mobile device should deep link to the app. If the app isn't installed, this endpoint will be called on the server side. Then we can redirect the user to the store. At this point only the App Store is supported but later in the stack Google Play will be also handled - based on the user agent. This is also the place where deferred part of linking will happen - setting referrer or clipboard item.
Details
Details
Create a test page containing a link to /invite/:secret. Clicking this link on a device with installed app results in opening the app with appropriate initialURL set. Clicking it on other devices opens the App Store.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/keyserver.js | ||
|---|---|---|
| 11 ↗ | (On Diff #24265) | Yeah, that's strange. I guess an import from cron might be confusing ESLint a little bit. I'll check if moving this import works. |
| 131 ↗ | (On Diff #24265) | That's correct - we will redirect to different url depending on the platform. I think we can do that based on user-agent. Using query string would require different urls for different platforms and I don't think it would be convenient (have to think about it). |
| keyserver/src/keyserver.js | ||
|---|---|---|
| 131 ↗ | (On Diff #24265) | Oops sorry I meant to say user agent instead of query string! |
| keyserver/src/keyserver.js | ||
|---|---|---|
| 11 ↗ | (On Diff #24265) | I think ESLint ignores the "naked imports" like ./cron/cron.js because it assumes they have side effects, and so the order probably matters for those Personally I would move the import './cron/cron.js'; to be next to the other local imports if possible, but it doesn't matter much |