Page MenuHomePhabricator
Differential D7237

[keyserver/lib] Optimistically create the toggle pin message
ClosedPublic
Actions

Authored by rohan on Mar 29 2023, 8:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
Unknown Object (File)
Mon, Mar 17, 9:20 PM
View All Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
Commits
rCOMM91e1c266462c: [keyserver/lib] Optimistically create the toggle pin message
Summary

We want to optimistically create the toggle pin message for the client pinning / unpinning the message.

Linear: https://linear.app/comm/issue/ENG-3542/optimistically-create-the-toggle-pin-message

Depends on D7220

Test Plan

Log onto an admin user and pin a message. Confirm that the message is created locally (note: the message is pinned via opening the media gallery just to test)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan created this revision.Mar 29 2023, 8:00 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 29 2023, 8:00 AM
rohan edited the summary of this revision. (Show Details)Mar 29 2023, 8:00 AM
rohan edited the test plan for this revision. (Show Details)
rohan added a parent revision: D7220: [keyserver] Update pinnedCount when a message is pinned and unpinned.
rohan attached a referenced file: F452313: Screen Recording 2023-03-29 at 10.30.20 AM.mov. (Show Details)
rohan edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B17783: Diff 24334.Mar 29 2023, 8:16 AM
rohan requested review of this revision.Mar 29 2023, 8:16 AM
atul accepted this revision.Mar 29 2023, 12:42 PM

Looks good!

This revision is now accepted and ready to land.Mar 29 2023, 12:42 PM
rohan updated this revision to Diff 24501.Mar 31 2023, 4:17 AM

Rebase

Harbormaster completed remote builds in B17886: Diff 24501.Mar 31 2023, 4:52 AM
rohan updated this revision to Diff 24826.Apr 7 2023, 11:12 AM

Rebase

Harbormaster completed remote builds in B18124: Diff 24826.Apr 7 2023, 11:30 AM
rohan updated this revision to Diff 24856.Apr 7 2023, 2:27 PM

Rebase before landing

Harbormaster completed remote builds in B18154: Diff 24856.Apr 7 2023, 3:00 PM
rohan updated this revision to Diff 24927.Apr 10 2023, 12:54 PM

Rebase

Harbormaster completed remote builds in B18203: Diff 24927.Apr 10 2023, 1:13 PM
rohan updated this revision to Diff 24991.Apr 11 2023, 8:46 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Apr 11 2023, 9:01 AM
Closed by commit rCOMM91e1c266462c: [keyserver/lib] Optimistically create the toggle pin message (authored by RohanK6 <rohan.khanderia@gmail.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
RohanK6 <rohan.khanderia@gmail.com> added a commit: rCOMM91e1c266462c: [keyserver/lib] Optimistically create the toggle pin message.
Harbormaster completed remote builds in B18248: Diff 24991.Apr 11 2023, 9:20 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
5 lines
updaters/
11 lines
lib/
actions/
15 lines
reducers/
4 lines
types/
17 lines
5 lines

Diff 24501

View Options

keyserver/src/responders/thread-responders.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { versionResponder } from './responders/version-responders.js';
import { import {
uploadMediaMetadataResponder, uploadMediaMetadataResponder,
uploadDeletionResponder, uploadDeletionResponder,
} from './uploads/uploads.js'; } from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: { get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder, responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
version: {
responder: versionResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

keyserver/src/updaters/thread-updaters.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { versionResponder } from './responders/version-responders.js';
import { import {
uploadMediaMetadataResponder, uploadMediaMetadataResponder,
uploadDeletionResponder, uploadDeletionResponder,
} from './uploads/uploads.js'; } from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: { get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder, responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
version: {
responder: versionResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/actions/thread-actions.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { versionResponder } from './responders/version-responders.js';
import { import {
uploadMediaMetadataResponder, uploadMediaMetadataResponder,
uploadDeletionResponder, uploadDeletionResponder,
} from './uploads/uploads.js'; } from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: { get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder, responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
version: {
responder: versionResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/reducers/message-reducer.js

Show First 20 Lines • Show All 70 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { versionResponder } from './responders/version-responders.js';
import { import {
uploadMediaMetadataResponder, uploadMediaMetadataResponder,
uploadDeletionResponder, uploadDeletionResponder,
} from './uploads/uploads.js'; } from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
▲ Show 20 Lines • Show All 218 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: { get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder, responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
version: {
responder: versionResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/thread-types.js

Loading...