[keyserver] Don't swallow identity service exceptions in logInResponder
ClosedPublic
Actions

Authored by ashoat on Mar 29 2023, 9:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 4:29 AM

	Unknown Object (File)
	Fri, Nov 8, 9:55 AM

	Unknown Object (File)
	Wed, Nov 6, 3:23 AM

	Unknown Object (File)
	Tue, Nov 5, 2:22 AM

	Unknown Object (File)
	Mon, Nov 4, 12:09 PM

	Unknown Object (File)
	Oct 28 2024, 2:56 PM

	Unknown Object (File)
	Oct 1 2024, 1:04 AM

	Unknown Object (File)
	Sep 29 2024, 5:48 PM

View All 87 Files

Subscribers

atul

tomek

Details

Reviewers

varun

Commits

rCOMM0f09a5ec2291: [keyserver] Don't swallow identity service exceptions in logInResponder

Test Plan

Make sure the error appears in the logs after this change (I tested in prod already)

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/identity

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 29 2023, 9:46 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 29 2023, 9:46 AM

Harbormaster completed remote builds in B17786: Diff 24337.Mar 29 2023, 10:02 AM

ashoat requested review of this revision.Mar 29 2023, 10:02 AM

varun accepted this revision.Mar 29 2023, 8:19 PM

This revision is now accepted and ready to land.Mar 29 2023, 8:19 PM

Closed by commit rCOMM0f09a5ec2291: [keyserver] Don't swallow identity service exceptions in logInResponder (authored by ashoat). · Explain WhyMar 30 2023, 6:15 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0f09a5ec2291: [keyserver] Don't swallow identity service exceptions in logInResponder.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

user-responders.js

2 lines

Diff 24337

View Options

keyserver/src/responders/user-responders.js

[keyserver] Don't swallow identity service exceptions in logInResponderClosedPublicActions