Page MenuHomePhabricator
Differential D7240

[keyserver] Redirect to the right store depending on the user agent
ClosedPublic
Actions

Authored by tomek on Mar 29 2023, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:55 AM
Unknown Object (File)
Wed, Nov 6, 3:23 AM
Unknown Object (File)
Tue, Nov 5, 4:46 AM
Unknown Object (File)
Tue, Nov 5, 4:46 AM
Unknown Object (File)
Tue, Nov 5, 2:23 AM
Unknown Object (File)
Oct 27 2024, 1:53 AM
Unknown Object (File)
Sep 29 2024, 5:48 PM
Unknown Object (File)
Sep 29 2024, 5:48 PM
View All 90 Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
ashoat
Commits
rCOMM5cafc8dec1dd: [keyserver] Redirect to the right store depending on the user agent
Summary

Use detect-browser to determine what OS user is using and redirect to App Store or Google Play Store.

Test Plan

Check on physical iOS and Android emulator if clicking /invite/:secret link opens the right store.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mar 29 2023, 9:47 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 29 2023, 9:47 AM
tomek added inline comments.Mar 29 2023, 9:49 AM
keyserver/package.json
51 ↗(On Diff #24338)

The same version as on web

keyserver/src/keyserver.js
131–138 ↗(On Diff #24338)

This will probably change again with web support

Harbormaster completed remote builds in B17787: Diff 24338.Mar 29 2023, 10:03 AM
tomek requested review of this revision.Mar 29 2023, 10:03 AM
ashoat accepted this revision.Mar 29 2023, 1:06 PM
This revision is now accepted and ready to land.Mar 29 2023, 1:06 PM
Closed by commit rCOMM5cafc8dec1dd: [keyserver] Redirect to the right store depending on the user agent (authored by tomek). · Explain WhyMar 30 2023, 6:45 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM5cafc8dec1dd: [keyserver] Redirect to the right store depending on the user agent.

Revision Contents
Changeset List

PathSize
keyserver/
1 line
src/
9 lines
lib/
facts/
2 lines

Diff 24385

View Options

keyserver/package.json

Loading...
View Options

keyserver/src/keyserver.js

Loading...
View Options

lib/facts/stores.js

Loading...