[desktop] Include generated native windows notifs
ClosedPublic
Actions

Authored by michal on Mar 30 2023, 5:48 AM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM1e1339f9cea0: [desktop] Include generated native windows notifs

Summary

This module was generated with NodeRT which generates native node modules from Windows API definitions. It doesn't build yet, changes required for it to work will be included in the later diff. The module is ignored for now in the monorepo and isn't built when running yarn commands.

It was generated using the UI version of the NodeRT:

winMD file was Microsoft.WindowsAppSDK.1.2.221109.1/lib/uap10.0/Microsoft.Windows.PushNotifications.winmd, where Microsoft.WindowsAppSdk.1.2.21109.1 is a nuget package
in namespaces I selected microsoft.windows.notification
I unselected generate "Generate TypeScript" and "Build module"

Test Plan

Check if it doesn't break yarn install

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Mar 30 2023, 5:48 AM

Herald added a subscriber: atul. · View Herald TranscriptMar 30 2023, 5:48 AM

Harbormaster completed remote builds in B17813: Diff 24379.Mar 30 2023, 6:04 AM

michal requested review of this revision.Mar 30 2023, 6:04 AM

michal added a child revision: D7218: [desktop] Modify the generated native windows notifs module.Mar 30 2023, 7:06 AM

I just had a 1:1 with @michal and asked for detailed instructions for how to generate this diff:

Get a Windows computer
Clone the NodeRT repository
Install Visual Studio 2022 Community Edition with C++ and C# Windows configurations
- @michal is not entirely sure if this is right; he will check his Windows computer and update before landing
Open the src/NodeRT.sln solution in the NodeRT repository with Visual Studio
Debug the src/NodeRTUI/NodeRTUI.csproj project

The NodeRTUI project is a GUI for generating NodeRT bindings. It will prompt for some things, and @michal's note in the diff description should cover everything you need to do:

It was generated using the UI version of the NodeRT:

winMD file was Microsoft.WindowsAppSDK.1.2.221109.1/lib/uap10.0/Microsoft.Windows.PushNotifications.winmd, where Microsoft.WindowsAppSdk.1.2.21109.1 is a nuget package

in namespaces I selected microsoft.windows.notification

I unselected generate "Generate TypeScript" and "Build module"

Then you select a folder (desktop/addons/windows-pushnotifications) and it will generate an NPM package (package.json) with all of the changes in this diff.

Note that @michal made two small modifications:

Adding eslint-disable to the top of main.js, so that our ESLint config wouldn't complain
Updating forge.config.cjs to ignore addons (the new NPM package will be included as a dependency in desktop/package.json instead)