Page MenuHomePhabricator
Differential D7278

[native] add edit avatar button for user avatar
ClosedPublic
Actions

Authored by ginsu on Apr 3 2023, 2:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 2, 6:52 AM
Unknown Object (File)
Thu, Jan 2, 6:52 AM
Unknown Object (File)
Thu, Jan 2, 6:52 AM
Unknown Object (File)
Thu, Jan 2, 6:52 AM
Unknown Object (File)
Thu, Jan 2, 6:47 AM
Unknown Object (File)
Fri, Dec 20, 1:22 AM
Unknown Object (File)
Dec 5 2024, 8:41 PM
Unknown Object (File)
Dec 5 2024, 8:41 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMba3b5a86358f: [native] add edit avatar button for user avatar
Summary

Add edit icon badge to user avatar in profile screen, and made user avatar in profile screen a touchable

Design:

Screenshot 2023-04-03 at 5.28.11 AM.png (1×670 px, 139 KB)

Test Plan

Please view the screenshots below to see the changes I made:

Screenshot 2023-04-03 at 5.27.14 AM.png (1×1 px, 402 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 3 2023, 2:30 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 3 2023, 2:30 AM
ginsu edited the summary of this revision. (Show Details)Apr 3 2023, 2:31 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu attached a referenced file: F459962: Screenshot 2023-04-03 at 5.27.14 AM.png. (Show Details)
ginsu attached a referenced file: F459961: Screenshot 2023-04-03 at 5.28.11 AM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B17922: Diff 24552.Apr 3 2023, 2:43 AM
ginsu requested review of this revision.Apr 3 2023, 2:43 AM
atul accepted this revision.Apr 3 2023, 1:31 PM
This revision is now accepted and ready to land.Apr 3 2023, 1:31 PM
ginsu updated this revision to Diff 24633.Apr 4 2023, 11:57 AM

rebase before landing

Harbormaster completed remote builds in B17981: Diff 24633.Apr 4 2023, 12:14 PM
Closed by commit rCOMMba3b5a86358f: [native] add edit avatar button for user avatar (authored by ginsu). · Explain WhyApr 4 2023, 12:15 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMba3b5a86358f: [native] add edit avatar button for user avatar.

Revision Contents
Changeset List

PathSize
native/
profile/
57 lines

Diff 24633

View Options

native/profile/profile-screen.react.js

Loading...