Extend CommIOSNotification module with method to send an event to JS to trigger message infos persistence
ClosedPublic
Actions

Authored by marcin on Apr 3 2023, 3:54 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMMcc4ab67a9f1d: Extend CommIOSNotification module with method to send an event to JS to trigger…

Summary

This differential adds method to CommIOSNotifications module that can send event to JS to persist in redux message infos that wasreceived by Notification Service Extension while the app was in the background.

Test Plan

Build the app. Call this method in didReceiveNotification callback in AppDelegate with dummy message infos. Subscribe in JS to log message infos to console.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Apr 3 2023, 3:54 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 3 2023, 3:54 AM

marcin added a child revision: D7285: Send Darwin Notification from NSE to AppDelegate so that it consumes flat file storage immediately and sends event to JS.Apr 3 2023, 4:00 AM

Harbormaster completed remote builds in B17934: Diff 24564.Apr 3 2023, 4:10 AM

marcin requested review of this revision.Apr 3 2023, 4:10 AM

tomek accepted this revision.Apr 7 2023, 2:23 AM

tomek added inline comments.

native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm
271 ↗	(On Diff #24564)	This string is used twice - maybe we can extract it to a constant?

This revision is now accepted and ready to land.Apr 7 2023, 2:23 AM

marcin added inline comments.Apr 11 2023, 6:33 AM

native/ios/Comm/CommIOSNotifications/CommIOSNotifications.mm
271 ↗	(On Diff #24564)	To be consistent we would have to do so for every string that represents a certain event we send to JS (each string in `supportedEvents` method is used twice in the same manner). This will be done along with https://linear.app/comm/issue/ENG-2842/export-javascript-event-names-as-constants-in-native-modules. For now I would leave it as it is in order to be consistent with the rest of the code.