Paths

Table of Contentst

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`
AbandonedPublic
Actions

Authored by atul on Apr 6 2023, 8:30 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 9:58 AM

	Unknown Object (File)
	Fri, Nov 8, 3:12 AM

	Unknown Object (File)
	Thu, Nov 7, 10:53 PM

	Unknown Object (File)
	Tue, Nov 5, 2:29 AM

	Unknown Object (File)
	Mon, Oct 28, 6:39 AM

	Unknown Object (File)
	Fri, Oct 25, 7:06 PM

	Unknown Object (File)
	Sep 28 2024, 8:02 AM

	Unknown Object (File)
	Sep 28 2024, 8:02 AM

View All 45 Files

Subscribers

rohan

tomek

Details

Reviewers

ashoat
ginsu
rohan

Summary

avatar field of Thread struct was previously implicitly NULL. However, @rohan is adding another field to the struct after avatar positionally which means we need to set avatar to NULL for now.

This is mostly to unblock @rohan, avatar construction from jsi::Object will be implemented correctly later in my stack.

Test Plan

Builds and runs. On call with @rohan things seemed to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 6 2023, 8:30 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 8:30 AM

JK this is handled by @rohan in D7211

Harbormaster completed remote builds in B18054: Diff 24740.Apr 6 2023, 8:47 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

3 lines

Diff 24740

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`AbandonedPublicActions