[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`
AbandonedPublic
Actions

Authored by atul on Apr 6 2023, 8:30 AM.

Details

Reviewers

ashoat
ginsu
rohan

Summary

avatar field of Thread struct was previously implicitly NULL. However, @rohan is adding another field to the struct after avatar positionally which means we need to set avatar to NULL for now.

This is mostly to unblock @rohan, avatar construction from jsi::Object will be implemented correctly later in my stack.

Test Plan

Builds and runs. On call with @rohan things seemed to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 6 2023, 8:30 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 8:30 AM

JK this is handled by @rohan in D7211

Harbormaster completed remote builds in B18054: Diff 24740.Apr 6 2023, 8:47 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

3 lines

Diff 24740

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 1,023 Lines • ▼ Show 20 Lines	): ReduceMessageStoreResult {
) {		) {
const payload = ensureRealizedThreadIDIsUsedWhenPossible(		const payload = ensureRealizedThreadIDIsUsedWhenPossible(
action.payload,		action.payload,
newThreadInfos,		newThreadInfos,
);		);
const { localID, threadID } = payload;		const { localID, threadID } = payload;
invariant(localID, `localID should be set on ${action.type}`);		invariant(localID, `localID should be set on ${action.type}`);

		const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];
		if (!messageStore.messages[localID]) {
		for (const existingMessageID of messageIDs) {
		const existingMessageInfo = messageStore.messages[existingMessageID];
		if (existingMessageInfo && existingMessageInfo.localID === localID) {
		return { messageStoreOperations: [], messageStore };
		}
		}
		}

const messageStoreOperations = [		const messageStoreOperations = [
{		{
type: 'replace',		type: 'replace',
payload: { id: localID, messageInfo: payload },		payload: { id: localID, messageInfo: payload },
},		},
];		];
const processedMessageStore = processMessageStoreOperations(
messageStore,
messageStoreOperations,
);

const now = Date.now();		const now = Date.now();
const messageIDs = messageStore.threads[threadID]?.messageIDs ?? [];		let updatedThreads;
		let local = { ...messageStore.local };
if (messageStore.messages[localID]) {		if (messageStore.messages[localID]) {
const messages = { ...messageStore.messages, [localID]: payload };		const messages = { ...messageStore.messages, [localID]: payload };
const local = _pickBy(		local = _pickBy(
(localInfo: LocalMessageInfo, key: string) => key !== localID,		(localInfo: LocalMessageInfo, key: string) => key !== localID,
)(messageStore.local);		)(messageStore.local);
const thread = messageStore.threads[threadID];		const thread = messageStore.threads[threadID];
const threads = {		updatedThreads = {
...messageStore.threads,
[threadID]: {		[threadID]: {
messageIDs: sortMessageIDs(messages)(messageIDs),		messageIDs: sortMessageIDs(messages)(messageIDs),
startReached: thread?.startReached ?? true,		startReached: thread?.startReached ?? true,
lastNavigatedTo: thread?.lastNavigatedTo ?? now,		lastNavigatedTo: thread?.lastNavigatedTo ?? now,
lastPruned: thread?.lastPruned ?? now,		lastPruned: thread?.lastPruned ?? now,
},		},
};		};
return {		} else {
messageStoreOperations,		updatedThreads = {
messageStore: {		[threadID]: messageStore.threads[threadID]
...messageStore,
messages: processedMessageStore.messages,
threads,
local,
},
};
}

for (const existingMessageID of messageIDs) {
const existingMessageInfo = messageStore.messages[existingMessageID];
if (existingMessageInfo && existingMessageInfo.localID === localID) {
return { messageStoreOperations: [], messageStore };
}
}

const threadState: ThreadMessageInfo = messageStore.threads[threadID]
? {		? {
...messageStore.threads[threadID],		...messageStore.threads[threadID],
messageIDs: [localID, ...messageIDs],		messageIDs: [localID, ...messageIDs],
}		}
: {		: {
messageIDs: [localID],		messageIDs: [localID],
startReached: true,		startReached: true,
lastNavigatedTo: now,		lastNavigatedTo: now,
lastPruned: now,		lastPruned: now,
		},
};		};
		}

return {		const threads = {
messageStoreOperations,
messageStore: {
messages: processedMessageStore.messages,
threads: {
...messageStore.threads,		...messageStore.threads,
[threadID]: threadState,		...updatedThreads,
		};
		messageStoreOperations.push({
		type: 'replace_threads',
		payload: {
		threads: { ...updatedThreads },
},		},
local: messageStore.local,		});

		const processedMessageStore = processMessageStoreOperations(
		messageStore,
		messageStoreOperations,
		);

		const newMessageStore = {
		messages: processedMessageStore.messages,
		threads,
		local,
currentAsOf: messageStore.currentAsOf,		currentAsOf: messageStore.currentAsOf,
},		};

		assertMessageStoreThreadsAreEqual(
		processedMessageStore,
		newMessageStore,
		action.type,
		);

		return {
		messageStoreOperations,
		messageStore: newMessageStore,
};		};
} else if (		} else if (
action.type === sendTextMessageActionTypes.failed \|\|		action.type === sendTextMessageActionTypes.failed \|\|
action.type === sendMultimediaMessageActionTypes.failed		action.type === sendMultimediaMessageActionTypes.failed
) {		) {
const { localID } = action.payload;		const { localID } = action.payload;
return {		return {
messageStoreOperations: [],		messageStoreOperations: [],
▲ Show 20 Lines • Show All 565 Lines • Show Last 20 Lines

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`AbandonedPublicActions