Page MenuHomePhabricator

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`
AbandonedPublic

Authored by atul on Apr 6 2023, 8:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 5:33 AM
Unknown Object (File)
Mar 7 2024, 7:38 AM
Unknown Object (File)
Feb 19 2024, 6:07 AM
Unknown Object (File)
Feb 19 2024, 12:53 AM
Unknown Object (File)
Feb 18 2024, 7:48 PM
Unknown Object (File)
Feb 6 2024, 1:03 PM
Unknown Object (File)
Feb 6 2024, 2:44 AM
Unknown Object (File)
Jan 6 2024, 3:38 PM
Subscribers

Details

Reviewers
ashoat
ginsu
rohan
Summary

avatar field of Thread struct was previously implicitly NULL. However, @rohan is adding another field to the struct after avatar positionally which means we need to set avatar to NULL for now.

This is mostly to unblock @rohan, avatar construction from jsi::Object will be implemented correctly later in my stack.

Test Plan

Builds and runs. On call with @rohan things seemed to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage