Page MenuHomePhabricator

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`
AbandonedPublic

Authored by atul on Apr 6 2023, 8:30 AM.
Tags
None
Referenced Files
F6156426: D7331.id.diff
Tue, Apr 22, 4:55 PM
Unknown Object (File)
Tue, Apr 22, 3:08 AM
Unknown Object (File)
Tue, Apr 22, 1:48 AM
Unknown Object (File)
Mon, Apr 21, 1:30 PM
Unknown Object (File)
Fri, Apr 18, 7:12 AM
Unknown Object (File)
Mar 17 2025, 12:11 PM
Unknown Object (File)
Mar 17 2025, 12:10 PM
Unknown Object (File)
Mar 17 2025, 12:01 PM
Subscribers

Details

Reviewers
ashoat
ginsu
rohan
Summary

avatar field of Thread struct was previously implicitly NULL. However, @rohan is adding another field to the struct after avatar positionally which means we need to set avatar to NULL for now.

This is mostly to unblock @rohan, avatar construction from jsi::Object will be implemented correctly later in my stack.

Test Plan

Builds and runs. On call with @rohan things seemed to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage