[lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` update
ClosedPublic
Actions

Authored by atul on Apr 6 2023, 12:05 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMa8bdde107683: [lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` update

Summary

We don't want to display anything about the updated value since we have no good way to display it (plus the user can just look at the thread header to see the updated avatar).

Depends on D7333

Test Plan

Before:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-04-06 at 14.26.29.png (2×1 px, 322 KB)

After:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-04-06 at 15.18.35.png (2×1 px, 262 KB)

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D7334 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 6 2023, 12:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 12:05 PM

atul published this revision for review.Apr 6 2023, 12:18 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B18058: Diff 24744.Apr 6 2023, 12:21 PM

ashoat accepted this revision.Apr 6 2023, 12:37 PM

This revision is now accepted and ready to land.Apr 6 2023, 12:37 PM

rebase ebfore landing

Harbormaster completed remote builds in B18059: Diff 24745.Apr 6 2023, 1:23 PM

Closed by commit rCOMMa8bdde107683: [lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` update (authored by atul). · Explain WhyApr 6 2023, 1:53 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa8bdde107683: [lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` update.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

change-settings-message-spec.js

4 lines

Diff 24745

View Options

lib/shared/messages/change-settings-message-spec.js

[lib] Update `ChangeSettingsMessageSpec` robotext for `avatar` updateClosedPublicActions