Page MenuHomePhabricator
Differential D7361

[keyserver] update login_user_wallet function
ClosedPublic
Actions

Authored by varun on Apr 7 2023, 12:59 PM.
Tags
None
Referenced Files
F2214629: D7361.diff
Mon, Jul 8, 5:35 PM
Unknown Object (File)
Mon, Jul 1, 5:40 AM
Unknown Object (File)
Sun, Jun 30, 12:46 AM
Unknown Object (File)
Sat, Jun 29, 11:07 PM
Unknown Object (File)
Fri, Jun 28, 9:04 AM
Unknown Object (File)
Tue, Jun 11, 8:36 AM
Unknown Object (File)
Tue, Jun 11, 8:36 AM
Unknown Object (File)
Tue, Jun 11, 8:30 AM
View All 61 Files
Subscribers
atul
tomek

Details

Reviewers
• jon
ashoat
Commits
rCOMM551c781b8ef8: [keyserver] update login_user_wallet function
Summary

updated the login_user_wallet function to use the new API specified in identity_client.proto

Depends on D7356

Test Plan

this will get tested later in the stack once i can rebase on jon's changes

Diff Detail

Repository
rCOMM Comm
Branch
rust-node-addon (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Apr 7 2023, 12:59 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptApr 7 2023, 12:59 PM
Harbormaster completed remote builds in B18133: Diff 24835.Apr 7 2023, 1:15 PM
varun requested review of this revision.Apr 7 2023, 1:15 PM
• jon accepted this revision.Apr 7 2023, 1:20 PM

Looks fine for a transition commit, still missing the other X3DH elements.

This revision is now accepted and ready to land.Apr 7 2023, 1:20 PM
ashoat resigned from this revision.Apr 7 2023, 6:11 PM

Defer to @jon, most of this is Rust and the rest of it follows from the Rust

Closed by commit rCOMM551c781b8ef8: [keyserver] update login_user_wallet function (authored by varun). · Explain WhyApr 10 2023, 12:28 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM551c781b8ef8: [keyserver] update login_user_wallet function.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
8 lines
src/
identity_client/
84 lines
6 lines
src/
responders/
4 lines
shared/
protos/
1 line

Diff 24835

View Options

keyserver/addons/rust-node-addon/rust-binding-types.js

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/login_user.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

keyserver/src/responders/user-responders.js

Loading...
View Options

shared/protos/identity_client.proto

Loading...