Page MenuHomePhabricator
Differential D7377

[keyserver] Update `deleteThread` and `deleteInaccessibleThreads` to handle thread image avatars
ClosedPublic
Actions

Authored by atul on Apr 10 2023, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:50 AM
Unknown Object (File)
Mon, Nov 18, 10:01 AM
Unknown Object (File)
Mon, Nov 18, 7:14 AM
Unknown Object (File)
Mon, Nov 18, 6:56 AM
Unknown Object (File)
Mon, Nov 18, 6:33 AM
Unknown Object (File)
Mon, Nov 18, 6:26 AM
Unknown Object (File)
Mon, Nov 18, 6:25 AM
Unknown Object (File)
Mon, Nov 18, 6:20 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM5c2bc957722a: [keyserver] Update `deleteThread` and `deleteInaccessibleThreads` to handle…
Summary

I looked through all of the DELETE queries in keyserver to see where we're handling deletion of threads. I found two queries (deleteThread and deleteInaccessibleThreads) that needed to be updated to handle deletion of thread avatar (AKA upload with container=threadID)

Depends on D7376

Test Plan
  1. Set image avatar for thread.
  2. Observe that container is set correctly in uploads table.
  3. Delete thread.
  4. Observe that row in uploads table has been removed.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7377 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 10 2023, 12:12 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 10 2023, 12:12 PM
atul edited the summary of this revision. (Show Details)Apr 10 2023, 12:13 PM
atul added a parent revision: D7376: [keyserver] Introduce `assignThreadContainerToMedia`.
atul published this revision for review.Apr 10 2023, 12:16 PM
Harbormaster completed remote builds in B18201: Diff 24921.Apr 10 2023, 12:28 PM
atul added a child revision: D7379: [keyserver] Update `deleteAccount` to handle user image avatars.Apr 10 2023, 1:14 PM
ashoat accepted this revision.Apr 10 2023, 1:24 PM
This revision is now accepted and ready to land.Apr 10 2023, 1:24 PM
ashoat added a comment.Apr 10 2023, 1:29 PM

This is safe because uploads has an index on container (would be good to note this in your Test Plan)

atul updated this revision to Diff 24975.Apr 11 2023, 8:23 AM

rebase and land

This revision was landed with ongoing or failed builds.Apr 11 2023, 8:25 AM
Closed by commit rCOMM5c2bc957722a: [keyserver] Update `deleteThread` and `deleteInaccessibleThreads` to handle… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM5c2bc957722a: [keyserver] Update `deleteThread` and `deleteInaccessibleThreads` to handle….
Harbormaster completed remote builds in B18234: Diff 24975.Apr 11 2023, 8:39 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
deleters/
4 lines

Diff 24975

View Options

keyserver/src/deleters/thread-deleters.js

Loading...