[Scripts] Ensure docker is running before starting localstack
ClosedPublic
Actions

Authored by • jon on Apr 11 2023, 7:29 AM.

Details

Reviewers

ashoat

Commits

rCOMM6bfd6f944723: [Scripts] Ensure docker is running before starting localstack

Summary

Localstack failing to start because docker isn't available
is not a good user experience as it outputs a bunch of "cannot open
socket" errors.

As part of starting localstack, ensure that docker is available before
attempting to launch localstack

https://linear.app/comm/issue/ENG-3227

Test Plan

# Stop docker
comm-dev services start
# Get message about starting docker

# Start docker
comm-dev services start
# Localstack starts

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Apr 11 2023, 7:29 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 11 2023, 7:29 AM

Harbormaster completed remote builds in B18233: Diff 24972.Apr 11 2023, 7:46 AM

• jon requested review of this revision.Apr 11 2023, 7:46 AM

• jon added inline comments.Apr 11 2023, 7:59 AM

scripts/comm-dev.sh
44–45 ↗	(On Diff #24972)	switched these because localstack is more likely to fail

Don’t have context

I wish you had deferred this work instead of randomly picking it up. You probably thought it would be easy, but now you have a diff and going to have to spend even more time on this responding to comments...

This is a huge distraction from your monthly goal, which you are deeply behind on. Even the scoping is incomplete!

I'm accepting this and removing reviewers to try to minimize the work that you have to do here. Before landing, please make sure you don't cause nix develop to fail if Localstack is not running. (An alternative solution would be to abandon the diff)

scripts/localstack_up.sh
22 ↗	(On Diff #24972)	Capitalize Docker Most devs do not need Localstack See my suggested edit, but please modify it to make sure each line does not exceed 80 chars

This revision is now accepted and ready to land.Apr 11 2023, 8:31 AM

Capitalize docker, revisit error message

$ comm-dev services start
Localstack requires Docker to be running
Please start Docker and try again

• jon marked an inline comment as done.Apr 11 2023, 9:02 AM

• jon added inline comments.

scripts/localstack_up.sh
22 ↗	(On Diff #24972)	"Docker doesn’t appear to be running. If you need Localstack for a local AWS environment, you’ll need to start Docker and try running `nix develop` again." `nix develop` doesn't start any of these services. It's invoked through the `comm-dev services` subcommand. $ comm-dev services start Localstack requires Docker, please start Docker and try again # Start docker $ comm-dev services start Starting Localstack...
22 ↗	(On Diff #24972)	Most devs do not need Localstack Correct, but for people working services, it's useful. Since I was trying to get a local dev environment going for Tunnelbroker, I thought I would fix this wrinkle that I tripped over.