Page MenuHomePhabricator

Send to the keyserver data necessary to initialize olm session for e2e notifications
AbandonedPublic

Authored by marcin on Apr 13 2023, 2:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 4:19 AM
Unknown Object (File)
Tue, Nov 5, 4:19 AM
Unknown Object (File)
Sun, Oct 27, 11:19 PM
Unknown Object (File)
Thu, Oct 17, 7:24 PM
Unknown Object (File)
Thu, Oct 17, 7:24 PM
Unknown Object (File)
Thu, Oct 17, 7:24 PM
Unknown Object (File)
Thu, Oct 17, 7:13 PM
Unknown Object (File)
Oct 9 2024, 7:00 AM
Subscribers

Details

Reviewers
tomek
atul
bartek
Summary

This differential sends necessary olm keys to initialize session for e2e notifications at the same time user logs-in/creates account

Test Plan

Build the app and test whether user can correctly log in or create account (including siwe). This will test that request validators work correctly. Additionally add console.log() in the keyserver codebase to print olm notifications keys to the console after extracting them from
the request.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 13 2023, 2:54 AM
Harbormaster failed remote builds in B18308: Diff 25086!
native/selectors/account-selectors.js
34–39 ↗(On Diff #25088)

Why are we waiting for commCoreModule.getUserPublicKey to finish before calling this?

native/selectors/account-selectors.js
34–39 ↗(On Diff #25088)

You are right - there is no reason not to await all those promises at once.

Adjust to new API of CryptoModule

This revision is now accepted and ready to land.Apr 17 2023, 6:50 AM

This differential will probably be abandoned.

This revision built foundation to send one time keys and prekey from client to the keyserver, which is no longer compliant with our architecture of E2E notifications.