Send to the keyserver data necessary to initialize olm session for e2e notifications
AbandonedPublic
Actions

Authored by marcin on Apr 13 2023, 2:35 AM.

Details

Reviewers

tomek
atul
bartek

Summary

This differential sends necessary olm keys to initialize session for e2e notifications at the same time user logs-in/creates account

Test Plan

Build the app and test whether user can correctly log in or create account (including siwe). This will test that request validators work correctly. Additionally add console.log() in the keyserver codebase to print olm notifications keys to the console after extracting them from
the request.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-3026

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 13 2023, 2:35 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 13 2023, 2:35 AM

marcin added a parent revision: D7395: Introduce methods in CommCoreModule to initialize olm session for notifications. Refactor method to get one time keys for primary olm account.Apr 13 2023, 2:35 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 13 2023, 2:54 AM

Harbormaster failed remote builds in B18308: Diff 25086!

Retrigger CI

Harbormaster completed remote builds in B18310: Diff 25088.Apr 13 2023, 3:23 AM

marcin requested review of this revision.Apr 13 2023, 3:23 AM

ashoat added inline comments.Apr 13 2023, 5:51 AM

native/selectors/account-selectors.js
34–39 ↗	(On Diff #25088)	Why are we waiting for `commCoreModule.getUserPublicKey` to finish before calling this?

marcin added inline comments.Apr 13 2023, 6:37 AM

native/selectors/account-selectors.js
34–39 ↗	(On Diff #25088)	You are right - there is no reason not to await all those promises at once.

Adjust to new API of CryptoModule

marcin added a child revision: D7463: Add table to store olm notifications sessions.Apr 17 2023, 3:50 AM

Harbormaster completed remote builds in B18403: Diff 25211.Apr 17 2023, 3:54 AM

atul accepted this revision.Apr 17 2023, 6:50 AM

This revision is now accepted and ready to land.Apr 17 2023, 6:50 AM

This differential will probably be abandoned.

This revision built foundation to send one time keys and prekey from client to the keyserver, which is no longer compliant with our architecture of E2E notifications.

marcin removed a child revision: D7463: Add table to store olm notifications sessions.Apr 21 2023, 2:35 AM