[native] extract processing store operations to separate function
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 7:57 AM.

Details

Reviewers

tomek
marcin

Commits

rCOMM42addc2abaa8: [native] extract processing store operations to separate function

Summary

In future there will be a need to call this from more places - to be precise here.
This action can not be moved lower in file to use the same code as previously as it's only-native and should be finalized before base reducer.

Test Plan

Check if operations are processed properly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 13 2023, 7:57 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 13 2023, 7:57 AM

kamil added a child revision: D7422: [native] generate operation for updating thread last navigated to.Apr 13 2023, 8:14 AM

Harbormaster completed remote builds in B18326: Diff 25110.Apr 13 2023, 8:16 AM

kamil published this revision for review.Apr 13 2023, 8:31 AM

ashoat added inline comments.Apr 15 2023, 7:03 AM

native/redux/redux-utils.js
20 ↗	(On Diff #25110)	I think this is a typo

tomek accepted this revision.Apr 17 2023, 6:39 AM

This revision is now accepted and ready to land.Apr 17 2023, 6:39 AM

fix typo

native/redux/redux-utils.js
20 ↗	(On Diff #25110)	yeah, thanks for catching

Harbormaster completed remote builds in B18521: Diff 25376.Apr 19 2023, 11:03 AM

Closed by commit rCOMM42addc2abaa8: [native] extract processing store operations to separate function (authored by kamil). · Explain WhyApr 19 2023, 11:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM42addc2abaa8: [native] extract processing store operations to separate function.

Revision Contents
Changeset List

Path

Size

native/

redux/

redux-setup.js

49 lines

redux-utils.js

55 lines

Diff 25379

View Options

native/redux/redux-setup.js