Page MenuHomePhabricator
Differential D7457

[native] add safe area insets for android action sheet
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:11 AM.
Tags
None
Referenced Files
F3363538: D7457.id25199.diff
Mon, Nov 25, 2:28 AM
Unknown Object (File)
Fri, Nov 22, 2:38 PM
Unknown Object (File)
Fri, Nov 22, 1:59 PM
Unknown Object (File)
Fri, Nov 22, 1:48 PM
Unknown Object (File)
Fri, Nov 22, 9:23 AM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
Unknown Object (File)
Thu, Nov 21, 11:55 PM
View All 99 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM73bb16e27bfd: [native] add safe area insets for android action sheet
Summary

Another thing I encountered when testing the action sheet for the edit avatar flow on android is that if the nav buttons are visible then it partly covers the most bottom option on the action sheet. To fix this I used SafeAreaContext to set the paddingBottom of the action sheet which fixes the issue.

Depends on D7456

Test Plan

Please check out the screenshots to see the changes I made

Before:

Screenshot 2023-04-16 at 1.26.56 PM.png (1×978 px, 843 KB)

After:

Screenshot 2023-04-16 at 1.28.50 PM.png (1×978 px, 841 KB)

w/o nav buttons:

Screenshot 2023-04-16 at 1.30.00 PM.png (1×978 px, 589 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 16 2023, 11:11 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:11 AM
ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:12 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7456: [native] fix Android cancel action sheet crash.
ginsu attached a referenced file: F488598: Screenshot 2023-04-16 at 1.30.00 PM.png. (Show Details)
ginsu attached a referenced file: F488597: Screenshot 2023-04-16 at 1.28.50 PM.png. (Show Details)
ginsu attached a referenced file: F488596: Screenshot 2023-04-16 at 1.26.56 PM.png. (Show Details)
Harbormaster completed remote builds in B18389: Diff 25195.Apr 16 2023, 11:29 AM
ginsu requested review of this revision.Apr 16 2023, 11:29 AM
ginsu updated this revision to Diff 25197.Apr 16 2023, 11:59 AM

rebase

ginsu updated this revision to Diff 25199.Apr 16 2023, 12:02 PM

fix merge conflict

Harbormaster completed remote builds in B18391: Diff 25197.Apr 16 2023, 12:18 PM
Harbormaster completed remote builds in B18393: Diff 25199.Apr 16 2023, 12:20 PM
ashoat accepted this revision.Apr 16 2023, 1:46 PM
This revision is now accepted and ready to land.Apr 16 2023, 1:46 PM
Closed by commit rCOMM73bb16e27bfd: [native] add safe area insets for android action sheet (authored by ginsu). · Explain WhyApr 16 2023, 3:40 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM73bb16e27bfd: [native] add safe area insets for android action sheet.

Revision Contents
Changeset List

PathSize
native/
tooltip/
6 lines

Diff 25197

View Options

native/tooltip/tooltip-context.react.js

Loading...