[lib] introduce getEthAddressForUserInfo helper function
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:52 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function

Summary

As I was attempting to introduce the use ens avatar option into EditAvatar I found that I needed the ethAddress again so I created this small helper function to reduce redundancy with this logic

Depends on D7460

Test Plan

flow and everything behaves as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 16 2023, 11:52 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:52 PM

ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:56 PM

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7460: [native] update save avatar hooks to accept all types of avatars.

Harbormaster completed remote builds in B18398: Diff 25206.Apr 17 2023, 12:10 AM

ginsu requested review of this revision.Apr 17 2023, 12:10 AM

ginsu added a child revision: D7462: [native] introduce use ens avatar option to edit avatar.Apr 17 2023, 12:39 AM

Please address inline comments before landing!

lib/utils/ens-helpers.js
11 ↗	(On Diff #25206)	Let's capitalize it this way for consistency with `userIdentifiedByETHAddress` etc.
11–20 ↗	(On Diff #25206)	I think it makes more sense to put this in the same file as `userIdentifiedByETHAddress`