Page MenuHomePhabricator
Differential D7461

[lib] introduce getEthAddressForUserInfo helper function
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 8:46 AM
Unknown Object (File)
Fri, Mar 7, 1:09 PM
Unknown Object (File)
Fri, Mar 7, 1:09 PM
Unknown Object (File)
Fri, Mar 7, 1:08 PM
Unknown Object (File)
Fri, Mar 7, 1:08 PM
Unknown Object (File)
Thu, Mar 6, 3:48 PM
Unknown Object (File)
Feb 27 2025, 11:37 PM
Unknown Object (File)
Jan 31 2025, 10:53 PM
View All 89 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function
Summary

As I was attempting to introduce the use ens avatar option into EditAvatar I found that I needed the ethAddress again so I created this small helper function to reduce redundancy with this logic

Depends on D7460

Test Plan

flow and everything behaves as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 16 2023, 11:52 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:52 PM
ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:56 PM
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7460: [native] update save avatar hooks to accept all types of avatars.
Harbormaster completed remote builds in B18398: Diff 25206.Apr 17 2023, 12:10 AM
ginsu requested review of this revision.Apr 17 2023, 12:10 AM
ginsu added a child revision: D7462: [native] introduce use ens avatar option to edit avatar.Apr 17 2023, 12:39 AM
ashoat accepted this revision.Apr 17 2023, 5:00 AM

Please address inline comments before landing!

lib/utils/ens-helpers.js
11 ↗(On Diff #25206)

Let's capitalize it this way for consistency with userIdentifiedByETHAddress etc.

11–20 ↗(On Diff #25206)

I think it makes more sense to put this in the same file as userIdentifiedByETHAddress

This revision is now accepted and ready to land.Apr 17 2023, 5:00 AM
ginsu updated this revision to Diff 25223.Apr 17 2023, 8:44 AM

address ashoat's comments

Harbormaster completed remote builds in B18412: Diff 25223.Apr 17 2023, 9:03 AM
Closed by commit rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function (authored by ginsu). · Explain WhyApr 17 2023, 11:52 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfebd68fc0df8: [lib] introduce getEthAddressForUserInfo helper function.

Revision Contents
Changeset List

PathSize
lib/
hooks/
6 lines
shared/
14 lines
15 lines
utils/
6 lines

Diff 25231

View Options

lib/hooks/ens-cache.js

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

lib/shared/account-utils.js

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

lib/shared/avatar-utils.js

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines
View Options

lib/utils/ens-helpers.js

Show All 10 Lines
div.messageActionContainer { div.messageActionContainer {
display: flex; display: flex;
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
border-radius: 8px; border-radius: 8px;
width: fit-content; width: fit-content;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.messageActionButtons { div.messageActionButtons {
display: flex; display: flex;
font-size: 16px; font-size: 16px;
} }
div.messageActionButtons svg { div.messageActionButtons svg {
padding: 10px 6px 6px; padding: 10px 6px 6px;
Show All 17 Linesdiv.messageTooltipLabel {
flex-direction: row; flex-direction: row;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
background-color: var(--message-action-tooltip-bg); background-color: var(--message-action-tooltip-bg);
color: var(--tool-tip-color); color: var(--tool-tip-color);
border-radius: 8px; border-radius: 8px;
overflow: auto; overflow: auto;
white-space: nowrap; white-space: nowrap;
box-shadow: var(--message-action-tooltip-bg) 0 2px 8px;
} }
div.leftTooltipAlign { div.leftTooltipAlign {
align-items: flex-start; align-items: flex-start;
} }
div.centerTooltipAlign { div.centerTooltipAlign {
align-items: center; align-items: center;
Show All 10 Lines