Page MenuHomePhabricator
Differential D7460

[native] update save avatar hooks to accept all types of avatars
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 7:31 AM
Unknown Object (File)
Thu, Dec 5, 2:41 AM
Unknown Object (File)
Thu, Dec 5, 2:29 AM
Unknown Object (File)
Thu, Dec 5, 2:28 AM
Unknown Object (File)
Nov 7 2024, 9:21 AM
Unknown Object (File)
Nov 7 2024, 9:11 AM
Unknown Object (File)
Nov 7 2024, 9:02 AM
Unknown Object (File)
Nov 6 2024, 3:21 AM
View All 96 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars
Summary

small fix to allow me to use these hooks to save all types of avatars (emoji, images, and ens)

Depends on D7459

Test Plan

Was still able to save emoji avatars and no flow errors if I would try and pass in a different avatar type for the newAvatarRequest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 16 2023, 11:46 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:46 PM
ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:47 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7459: [native] have actionsheet pop up on press when editing avatar.
ginsu retitled this revision from [native] update save avatar hook parameter types to accept all types of avatars to [native] update save avatar hooks to accept all types of avatars.
ginsu added a child revision: D7461: [lib] introduce getEthAddressForUserInfo helper function.Apr 16 2023, 11:56 PM
Harbormaster completed remote builds in B18397: Diff 25205.Apr 17 2023, 12:04 AM
ginsu requested review of this revision.Apr 17 2023, 12:04 AM
ashoat accepted this revision.Apr 17 2023, 4:55 AM
This revision is now accepted and ready to land.Apr 17 2023, 4:55 AM
Closed by commit rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars (authored by ginsu). · Explain WhyApr 17 2023, 8:37 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars.

Revision Contents
Changeset List

PathSize
native/
utils/
14 lines

Diff 25222

View Options

native/utils/avatar-utils.js

Loading...