Page MenuHomePhabricator
Differential D7460

[native] update save avatar hooks to accept all types of avatars
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 3:42 AM
Unknown Object (File)
Feb 27 2025, 5:48 AM
Unknown Object (File)
Feb 24 2025, 3:26 PM
Unknown Object (File)
Feb 24 2025, 3:26 PM
Unknown Object (File)
Feb 24 2025, 3:26 PM
Unknown Object (File)
Jan 14 2025, 5:14 PM
Unknown Object (File)
Jan 14 2025, 5:14 PM
Unknown Object (File)
Jan 14 2025, 5:13 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars
Summary

small fix to allow me to use these hooks to save all types of avatars (emoji, images, and ens)

Depends on D7459

Test Plan

Was still able to save emoji avatars and no flow errors if I would try and pass in a different avatar type for the newAvatarRequest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 16 2023, 11:46 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:46 PM
ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:47 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7459: [native] have actionsheet pop up on press when editing avatar.
ginsu retitled this revision from [native] update save avatar hook parameter types to accept all types of avatars to [native] update save avatar hooks to accept all types of avatars.
ginsu added a child revision: D7461: [lib] introduce getEthAddressForUserInfo helper function.Apr 16 2023, 11:56 PM
Harbormaster completed remote builds in B18397: Diff 25205.Apr 17 2023, 12:04 AM
ginsu requested review of this revision.Apr 17 2023, 12:04 AM
ashoat accepted this revision.Apr 17 2023, 4:55 AM
This revision is now accepted and ready to land.Apr 17 2023, 4:55 AM
Closed by commit rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars (authored by ginsu). · Explain WhyApr 17 2023, 8:37 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8fb4e45445b1: [native] update save avatar hooks to accept all types of avatars.

Revision Contents
Changeset List

PathSize
native/
utils/
14 lines

Diff 25222

View Options

native/utils/avatar-utils.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS # STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes # Install prereqs first so we don't have to reinstall them if anything changes
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# We use rsync in the prod-build yarn script # We add Debian's unstable repo since it's the only way to get mysqldump
RUN echo "deb http://deb.debian.org/debian unstable main non-free contrib" \
>> /etc/apt/sources.list
# We need rsync in the prod-build yarn script
# We need mysql-client so we can use mysqldump for backups
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
rsync \ rsync \
mysql-client \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 1: DEVOLVE PRIVILEGES # STEP 1: DEVOLVE PRIVILEGES
# Create another user to run the rest of the commands # Create another user to run the rest of the commands
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
RUN useradd -m comm RUN useradd -m comm
USER comm USER comm
WORKDIR /home/comm/app WORKDIR /home/comm/app
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 2: INSTALL NVM # STEP 2: SET UP MYSQL BACKUPS
# Prepare the system to properly handle mysqldump backups
#-------------------------------------------------------------------------------
# Prepare the directory that will hold the backups
RUN mkdir /home/comm/mysqldump
# We install mysql-client 8.0 above but use it with MySQL 5.7. Unfortunately,
# we haven't been able to figure out a way to install mysql-client 5.7 on
# Debian bullseye. Instead, we configure mysqldump 8.0 to work with MySQL 5.7
RUN echo "[mysqldump]\ncolumn-statistics=0" > /home/comm/.my.cnf
#-------------------------------------------------------------------------------
# STEP 3: INSTALL NVM
# We use nvm to make sure we're running the right Node version # We use nvm to make sure we're running the right Node version
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
ENV NVM_DIR /home/comm/.nvm ENV NVM_DIR /home/comm/.nvm
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \ RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh \
| bash | bash
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 3: YARN CLEANINSTALL # STEP 4: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching # We run yarn cleaninstall before copying most of the files in for build caching
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY --chown=comm package.json yarn.lock . COPY --chown=comm package.json yarn.lock .
COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/ COPY --chown=comm keyserver/package.json keyserver/.flowconfig keyserver/
COPY --chown=comm lib/package.json lib/.flowconfig lib/ COPY --chown=comm lib/package.json lib/.flowconfig lib/
COPY --chown=comm web/package.json web/.flowconfig web/ COPY --chown=comm web/package.json web/.flowconfig web/
COPY --chown=comm native/package.json native/.flowconfig native/ COPY --chown=comm native/package.json native/.flowconfig native/
COPY --chown=comm landing/package.json landing/.flowconfig landing/ COPY --chown=comm landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY --chown=comm patches patches/ COPY --chown=comm patches patches/
COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/ COPY --chown=comm native/ios/pod-patch native/ios/pod-patch/
COPY --chown=comm native/ios/Podfile native/ios/ COPY --chown=comm native/ios/Podfile native/ios/
# Actually run yarn # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 4: WEBPACK BUILD # STEP 5: WEBPACK BUILD
# We do this first so Docker doesn't rebuild when only keyserver files change # We do this first so Docker doesn't rebuild when only keyserver files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm lib lib/ COPY --chown=comm lib lib/
COPY --chown=comm landing landing/ COPY --chown=comm landing landing/
RUN yarn workspace landing prod RUN yarn workspace landing prod
COPY --chown=comm web web/ COPY --chown=comm web web/
RUN yarn workspace web prod RUN yarn workspace web prod
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 5: COPY IN SOURCE FILES # STEP 6: COPY IN SOURCE FILES
# We run this later so the above layers are cached if only source files change # We run this later so the above layers are cached if only source files change
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
COPY --chown=comm . . COPY --chown=comm . .
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 6: RUN BUILD SCRIPTS # STEP 7: RUN BUILD SCRIPTS
# We need to populate keyserver/dist, among other things # We need to populate keyserver/dist, among other things
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# Babel transpilation of keyserver src # Babel transpilation of keyserver src
RUN yarn workspace keyserver prod-build RUN yarn workspace keyserver prod-build
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
# STEP 7: RUN THE SERVER # STEP 8: RUN THE SERVER
# Actually run the Node.js keyserver using nvm # Actually run the Node.js keyserver using nvm
#------------------------------------------------------------------------------- #-------------------------------------------------------------------------------
EXPOSE 3000 EXPOSE 3000
WORKDIR /home/comm/app/keyserver WORKDIR /home/comm/app/keyserver
CMD bash/run-prod.sh CMD bash/run-prod.sh