Page MenuHomePhabricator

[native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional
ClosedPublic

Authored by atul on Apr 17 2023, 4:32 PM.
Tags
None
Referenced Files
F2207052: D7478.id25261.diff
Sun, Jul 7, 5:18 AM
Unknown Object (File)
Fri, Jul 5, 8:51 PM
Unknown Object (File)
Wed, Jul 3, 3:37 AM
Unknown Object (File)
Tue, Jul 2, 12:28 PM
Unknown Object (File)
Mon, Jul 1, 12:49 AM
Unknown Object (File)
Sun, Jun 30, 4:06 AM
Unknown Object (File)
Thu, Jun 27, 4:37 PM
Unknown Object (File)
Sat, Jun 15, 10:09 PM
Subscribers

Details

Summary

The config argument of processMedia is of type MediaProcessConfig. Until now, the only processMedia callsite has been in InputStateContainer where we've always passed on onTranscodingProgress.

However, we now want to use processMedia(...) in EditAvatar where we DON'T want to set onTranscodingProgress (we don't support video avatars so there's zero use).

Why not just use processImage instead of processMedia?

processMedia doesn't just branch between processImage or processVideo based on type. There's a lot of common logic in processMedia that's required for both images and videos.

Test Plan

Make sure transcoding progress still displayed properly for video messages:

e76904.png (452×632 px, 192 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable