Page MenuHomePhabricator

[native] Make `onTranscodingProgress` field of `MediaProcessConfig` optional
ClosedPublic

Authored by atul on Apr 17 2023, 4:32 PM.
Tags
None
Referenced Files
F3396223: D7478.diff
Sun, Dec 1, 11:12 AM
Unknown Object (File)
Fri, Nov 29, 8:46 AM
Unknown Object (File)
Mon, Nov 11, 3:06 PM
Unknown Object (File)
Mon, Nov 11, 2:32 PM
Unknown Object (File)
Sat, Nov 9, 8:36 PM
Unknown Object (File)
Sat, Nov 9, 8:36 PM
Unknown Object (File)
Sat, Nov 9, 8:36 PM
Unknown Object (File)
Fri, Nov 8, 9:22 PM
Subscribers

Details

Summary

The config argument of processMedia is of type MediaProcessConfig. Until now, the only processMedia callsite has been in InputStateContainer where we've always passed on onTranscodingProgress.

However, we now want to use processMedia(...) in EditAvatar where we DON'T want to set onTranscodingProgress (we don't support video avatars so there's zero use).

Why not just use processImage instead of processMedia?

processMedia doesn't just branch between processImage or processVideo based on type. There's a lot of common logic in processMedia that's required for both images and videos.

Test Plan

Make sure transcoding progress still displayed properly for video messages:

e76904.png (452×632 px, 192 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage